From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1754502AbdEQO5d (ORCPT <rfc822;w@1wt.eu>);
        Wed, 17 May 2017 10:57:33 -0400
Received: from resqmta-ch2-08v.sys.comcast.net ([69.252.207.40]:46056 "EHLO
        resqmta-ch2-08v.sys.comcast.net" rhost-flags-OK-OK-OK-OK)
        by vger.kernel.org with ESMTP id S1751531AbdEQO5a (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 17 May 2017 10:57:30 -0400
Date: Wed, 17 May 2017 09:57:28 -0500 (CDT)
From: Christoph Lameter <cl@linux.com>
X-X-Sender: cl@east.gentwo.org
To: Wei Yang <richard.weiyang@gmail.com>
cc: penberg@kernel.org, rientjes@google.com, akpm@linux-foundation.org,
        linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/6] refine and rename slub sysfs
In-Reply-To: <20170517141146.11063-1-richard.weiyang@gmail.com>
Message-ID: <alpine.DEB.2.20.1705170954090.8714@east.gentwo.org>
References: <20170517141146.11063-1-richard.weiyang@gmail.com>
Content-Type: text/plain; charset=US-ASCII
X-CMAE-Envelope: MS4wfLwqo2MNB9OyDiPafCQRiJg7F0Ucqw4vwPYcjDc9ypFWuo1qRL6jQ5YTmEQsMYiyiXjyEIb7B7JYhMkrdZ342SV8/kuy1JtSx6d332772O0oFkr1JHNc
 JbStV079Tc9+Shc93w04+2oyWbkBsogG+o4tjMvYbTqlQh3NoFbPL226AK67v1nLdlsmI+ZmVfUXGk+bVmXBZt0JLDtN9yHvOVPCZRx2lGGtY6rIj4vanHnb
 gF/Y6K+meaoPQd5MtmUEy4qVsP2o2ZA5+J77EiI1m8aY7HCilXuLrWzuyzZ8XrHsGwVok7qLXX61QDoG1aWeY1Wv8thv7FOMvLrD4Cp7BUM=
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, 17 May 2017, Wei Yang wrote:

> This patch serial could be divided into two parts.
>
> First three patches refine and adds slab sysfs.
> Second three patches rename slab sysfs.

These changes will break the slabinfo tool in linux/tools/vm/slabinfo.c.
Please update it as well.

> 1. Refine slab sysfs
>
> There are four level slabs:

levels? Maybe types of slabs?

>     CPU
>     CPU_PARTIAL
>     PARTIAL
>     FULL
>
> And in sysfs, it use show_slab_objects() and cpu_partial_slabs_show() to
> reflect the statistics.
>
> In patch 2, it splits some function in show_slab_objects() which makes sure
> only cpu_partial_slabs_show() covers statistics for CPU_PARTIAL slabs.
>
> After doing so, it would be more clear that show_slab_objects() has totally 9
> statistic combinations for three level of slabs. Each slab has three cases
> statistic.
>
>     slabs
>     objects
>     total_objects

That sounds good.

> which is a little bit hard for users to understand. The second three patches
> rename sysfs file in this pattern.
>
>     xxx_slabs[[_total]_objects]
>
> Finally it looks Like
>
>     slabs
>     slabs_objects
>     slabs_total_objects
>     cpu_slabs
>     cpu_slabs_objects
>     cpu_slabs_total_objects
>     partial_slabs
>     partial_slabs_objects
>     partial_slabs_total_objects
>     cpu_partial_slabs

Arent we missing:

cpu_partial_slabs_objects
cpu_partial_slabs_total_objects

And the partial slabs exclude the cpu slabs as well as the cpu_partial
slabs?

Could you add some documentation as well to explain the exact semantics?