linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: Christoph Hellwig <hch@lst.de>
Cc: Jens Axboe <axboe@kernel.dk>, Keith Busch <keith.busch@intel.com>,
	linux-nvme@lists.infradead.org, linux-block@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/7] genirq/affinity: factor out a irq_affinity_set helper
Date: Sun, 21 May 2017 21:03:06 +0200 (CEST)	[thread overview]
Message-ID: <alpine.DEB.2.20.1705212052000.3023@nanos> (raw)
In-Reply-To: <20170519085756.29742-4-hch@lst.de>

On Fri, 19 May 2017, Christoph Hellwig wrote:

> Factor out code from the x86 cpu hot plug code to program the affinity
> for a vector for a hot plug / hot unplug event.
> +bool irq_affinity_set(int irq, struct irq_desc *desc, const cpumask_t *mask)
> +{
> +	struct irq_data *data = irq_desc_get_irq_data(desc);
> +	struct irq_chip *chip = irq_data_get_irq_chip(data);
> +	bool ret = false;
> +
> +	if (!irqd_can_move_in_process_context(data) && chip->irq_mask)

Using that inline directly will make this function useless on architectures
which have GENERIC_PENDING_IRQS not set.

kernel/irq/manage.c has that wrapped. We need to move those wrappers to the
internal header file, so that it gets compiled out on other platforms.

Thanks,

	tglx

  reply	other threads:[~2017-05-21 19:03 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-19  8:57 spread MSI(-X) vectors to all possible CPUs V2 Christoph Hellwig
2017-05-19  8:57 ` [PATCH 1/7] genirq: allow assigning affinity to present but not online CPUs Christoph Hellwig
2017-05-19  8:57 ` [PATCH 2/7] genirq/affinity: assign vectors to all present CPUs Christoph Hellwig
2017-05-21 18:31   ` Thomas Gleixner
2017-05-23  9:35     ` Christoph Hellwig
2017-05-19  8:57 ` [PATCH 3/7] genirq/affinity: factor out a irq_affinity_set helper Christoph Hellwig
2017-05-21 19:03   ` Thomas Gleixner [this message]
2017-05-23  9:37     ` Christoph Hellwig
2017-05-19  8:57 ` [PATCH 4/7] genirq/affinity: update CPU affinity for CPU hotplug events Christoph Hellwig
2017-05-19  8:57 ` [PATCH 5/7] blk-mq: include all present CPUs in the default queue mapping Christoph Hellwig
2017-05-19  8:57 ` [PATCH 6/7] blk-mq: create hctx for each present CPU Christoph Hellwig
2017-05-19  8:57 ` [PATCH 7/7] nvme: allocate queues for all possible CPUs Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.20.1705212052000.3023@nanos \
    --to=tglx@linutronix.de \
    --cc=axboe@kernel.dk \
    --cc=hch@lst.de \
    --cc=keith.busch@intel.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).