From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933646AbdEXQEF (ORCPT ); Wed, 24 May 2017 12:04:05 -0400 Received: from resqmta-ch2-04v.sys.comcast.net ([69.252.207.36]:45508 "EHLO resqmta-ch2-04v.sys.comcast.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758009AbdEXQED (ORCPT ); Wed, 24 May 2017 12:04:03 -0400 Date: Wed, 24 May 2017 11:03:58 -0500 (CDT) From: Christoph Lameter X-X-Sender: cl@east.gentwo.org To: Wei Yang cc: Michal Hocko , penberg@kernel.org, rientjes@google.com, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/6] refine and rename slub sysfs In-Reply-To: <20170524152124.GB8445@WeideMacBook-Pro.local> Message-ID: References: <20170517141146.11063-1-richard.weiyang@gmail.com> <20170518090636.GA25471@dhcp22.suse.cz> <20170523032705.GA4275@WeideMBP.lan> <20170523063911.GC12813@dhcp22.suse.cz> <20170524095450.GA7706@WeideMBP.lan> <20170524120318.GE14733@dhcp22.suse.cz> <20170524152124.GB8445@WeideMacBook-Pro.local> Content-Type: text/plain; charset=US-ASCII X-CMAE-Envelope: MS4wfD7rVA0NZHy6TlJm1xa+yvl/G+QhKdUHLVZpMSGtSCUKP96+xMBijwVC+hhtaum6+HU/73T/KwRXexLj0TiCsAjwCFu0/RoVC3FHBj9dJ2HG3glW5CFp IAIeRuW/V/eLYdAgfAoc6Zz4ELRz+5crFzZj9eN35Xh4lan2lFyNwLmNUHI8PCSil3xbrY3gNENZCSE5yZHRoYK56E0YyrVXS4D1RocHjncOR/lSJQJ0Qifk RSsauBaVsCyz/x9ycxzaMlaWSiq8Kc0qYXqQU6MmiMulBzkAKow3/glI2eyFjXD0GCSvguY+Tu95JRMFwTSJnUQyCZNIRGbDQME0EOtNKXPIfvtIiONKXtoQ 2FLwndW3 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 24 May 2017, Wei Yang wrote: > > > >Who is going to use those new entries and for what purpose? Why do we > >want to expose even more details of the slab allocator to the userspace. > >Is the missing information something fundamental that some user space > >cannot work without it? Seriously these are essential questions you > >should have answer for _before_ posting the patch and mention all those > >reasons in the changelog. > > It is me who wants to get more details of the slub behavior. > AFAIK, no one else is expecting this. I would appreciate some clearer structured statistics. These are important for diagnostics and for debugging. Do not go overboard with this. Respin it and provide also a cleanup of the slabinfo tool? I would appreciate it. > Hmm, if we really don't want to export these entries, why not remove related > code? Looks we are sure they will not be touched. Please have a look at the slabinfo code which depends on those fields in order to display slab information. I have patchsets here that will add more functionality to slab and those will also add additional fields to sysfs.