From: Thomas Gleixner <tglx@linutronix.de>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Marcin Nowakowski <marcin.nowakowski@imgtec.com>,
Andrew Morton <akpm@linux-foundation.org>,
"Peter Zijlstra (Intel)" <peterz@infradead.org>,
Thomas Meyer <thomas@m3y3r.de>, Ingo Molnar <mingo@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Paul Gortmaker <paul.gortmaker@windriver.com>,
Masami Hiramatsu <mhiramat@kernel.org>,
linux-kernel@vger.kernel.org, linux-mips@linux-mips.org
Subject: Re: [PATCH] kernel/extable.c: mark core_kernel_text notrace
Date: Fri, 23 Jun 2017 00:16:36 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.20.1706230012150.2221@nanos> (raw)
In-Reply-To: <20170622181050.220c23a3@gandalf.local.home>
On Thu, 22 Jun 2017, Steven Rostedt wrote:
> On Wed, 21 Jun 2017 09:03:26 +0200
> Marcin Nowakowski <marcin.nowakowski@imgtec.com> wrote:
> >
> > -int core_kernel_text(unsigned long addr)
> > +int notrace core_kernel_text(unsigned long addr)
>
> Is mips the only one with this issue. I hate adding notrace to general
> functions if it is only an issue with a single arch.
We have unwinders using that function and btw, ftrace has a similar issue
with core_kernel_data(). Probably not endless recursive, but not pretty
either if you have trace entries from within the tracer itself.
> Can we add a: mips_notrace? where we have:
>
> #ifdef CONFIG_MIPS
> # define mips_notrace notrace
> #else
> # define mips_notrace
> #endif
We can, but that will explode into an unholy mess sooner than later. I know
you'd love to come up with the most convoluted macro magic to make that
happen.
Thanks,
tglx
prev parent reply other threads:[~2017-06-22 22:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-21 7:03 [PATCH] kernel/extable.c: mark core_kernel_text notrace Marcin Nowakowski
2017-06-22 10:24 ` Masami Hiramatsu
2017-06-22 22:10 ` Steven Rostedt
2017-06-22 22:16 ` Thomas Gleixner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1706230012150.2221@nanos \
--to=tglx@linutronix.de \
--cc=akpm@linux-foundation.org \
--cc=daniel@iogearbox.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=marcin.nowakowski@imgtec.com \
--cc=mhiramat@kernel.org \
--cc=mingo@kernel.org \
--cc=paul.gortmaker@windriver.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=thomas@m3y3r.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).