From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751849AbdGBNQd (ORCPT <rfc822;w@1wt.eu>);
        Sun, 2 Jul 2017 09:16:33 -0400
Received: from Galois.linutronix.de ([146.0.238.70]:39644 "EHLO
        Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1750818AbdGBNQb (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Sun, 2 Jul 2017 09:16:31 -0400
Date: Sun, 2 Jul 2017 15:16:24 +0200 (CEST)
From: Thomas Gleixner <tglx@linutronix.de>
To: Vikas Shivappa <vikas.shivappa@linux.intel.com>
cc: x86@kernel.org, linux-kernel@vger.kernel.org, hpa@zytor.com,
        peterz@infradead.org, ravi.v.shankar@intel.com,
        vikas.shivappa@intel.com, tony.luck@intel.com, fenghua.yu@intel.com,
        andi.kleen@intel.com
Subject: Re: [PATCH 15/21] x86/intel_rdt/cqm: Add rmdir support
In-Reply-To: <1498503368-20173-16-git-send-email-vikas.shivappa@linux.intel.com>
Message-ID: <alpine.DEB.2.20.1707021509130.2296@nanos>
References: <1498503368-20173-1-git-send-email-vikas.shivappa@linux.intel.com> <1498503368-20173-16-git-send-email-vikas.shivappa@linux.intel.com>
User-Agent: Alpine 2.20 (DEB 67 2015-01-07)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, 26 Jun 2017, Vikas Shivappa wrote:

> Resource groups (ctrl_mon and monitor groups) are represented by
> directories in resctrl fs. Add support to remove the directories.

Again. Please split that patch into two parts; seperate ctrl stuff from rmdir and
then add monitoring support.

> +	rdtgrp->flags = RDT_DELETED;
> +	free_rmid(rdtgrp->rmid);
> +
> +	/*
> +	 * Remove your rmid from the parent ctrl groups list

You are not removing a rmid. You remove the group from the parents group
list. Please be more accurate with your comments. Wrong comments are worse
than no comments.

> +	WARN_ON(list_empty(&prdtgrp->crdtgrp_list));
> +	list_del(&rdtgrp->crdtgrp_list);

> +static int rdtgroup_rmdir_ctrl(struct kernfs_node *kn, struct rdtgroup *rdtgrp)
> +{
> +	int cpu, closid = rdtgroup_default.closid;
> +	struct rdtgroup *entry, *tmp;
> +	struct list_head *llist;

*head please.

> +	cpumask_var_t tmpmask;
> +
> +	if (!zalloc_cpumask_var(&tmpmask, GFP_KERNEL))
> +		return -ENOMEM;

Allocation/free can be done at the call site for both functions.

> +static int rdtgroup_rmdir(struct kernfs_node *kn)
> +{
> +	struct kernfs_node *parent_kn = kn->parent;
> +	struct rdtgroup *rdtgrp;
> +	int ret = 0;
> +
> +	rdtgrp = rdtgroup_kn_lock_live(kn);
> +	if (!rdtgrp) {
> +		ret = -EPERM;
> +		goto out;
> +	}
> +
> +	if (rdtgrp->type == RDTCTRL_GROUP && parent_kn == rdtgroup_default.kn)
> +		ret = rdtgroup_rmdir_ctrl(kn, rdtgrp);
> +	else if (rdtgrp->type == RDTMON_GROUP &&
> +		 !strcmp(parent_kn->name, "mon_groups"))
> +		ret = rdtgroup_rmdir_mon(kn, rdtgrp);
> +	else
> +		ret = -EPERM;

Like in the other patch, please makes this parseable.

Thanks,

	tglx