From: Julia Lawall <julia.lawall@lip6.fr>
To: Sebastian Reichel <sebastian.reichel@collabora.co.uk>
Cc: Andy Shevchenko <andy.shevchenko@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
kernel-janitors@vger.kernel.org,
Gilles Muller <Gilles.Muller@lip6.fr>,
Nicolas Palix <nicolas.palix@imag.fr>,
Michal Marek <mmarek@suse.com>,
cocci@systeme.lip6.fr,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Benjamin Tissoires <benjamin.tissoires@redhat.com>,
Bastien Nocera <hadess@hadess.net>,
Stephen Just <stephenjust@gmail.com>,
"Rafael J . Wysocki" <rafael.j.wysocki@intel.com>,
Len Brown <lenb@kernel.org>,
Robert Moore <robert.moore@intel.com>,
Lv Zheng <lv.zheng@intel.com>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
devel@acpica.org,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>
Subject: Re: [PATCH] coccinelle: api: detect unnecessary le16_to_cpu
Date: Tue, 4 Jul 2017 11:11:20 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.20.1707041104390.3346@hadrien> (raw)
In-Reply-To: <20170703182033.5stv5eq33et63coh@earth>
Here is a revised version (not a patch because it doesn't support all of
the various modes) and the results. It doesn't return anything beyond
what was mentioned in previous mails.
For the following code:
ret = i2c_smbus_read_word_data(chip->client, reg << 1);
val[0] = (u16)ret & 0xFF;
val[1] = (u16)ret >> 8;
do we want to see:
put_unaligned(val,i2c_smbus_read_word_data(chip->client, reg << 1));
julia
---
@@
expression e, x;
@@
* x = i2c_smbus_read_word_data(...)
... when != x = e
* le16_to_cpu(x)
@@
expression e, e1, x, y;
@@
* x = i2c_smbus_read_word_data(...)
... when != x = e
* y = x;
... when != y = e1
* le16_to_cpu(y)
@@
@@
* le16_to_cpu(i2c_smbus_read_word_data(...))
// -------------------------------------------------------------
@@
expression e, e1, e2, x;
type T;
@@
* x = cpu_to_le16(...)
... when != x = e
* i2c_smbus_write_word_data(e1,e2,(T)x)
@@
expression e, e1, e2, e3, x, y;
type T;
@@
* x = cpu_to_le16(...)
... when != x = e
* y = x
... when != y = e3
* i2c_smbus_write_word_data(e1,e2,(T)y)
@@
expression e1,e2;
@@
* i2c_smbus_write_word_data(e1,e2,cpu_to_le16(...))
// -------------------------------------------------------------
@@
expression e1,e2;
typedef u16;
@@
* e1[0] = (u16)e2 & 0xFF;
e1[1] = (u16)e2 >> 8;
---
- means line of interest, not line to remove.
diff -u -p a/drivers/gpio/gpio-pca953x.c b/drivers/gpio/gpio-pca953x.c
--- a/drivers/gpio/gpio-pca953x.c
+++ b/drivers/gpio/gpio-pca953x.c
@@ -187,10 +187,7 @@ static int pca953x_write_regs_8(struct p
static int pca953x_write_regs_16(struct pca953x_chip *chip, int reg, u8 *val)
{
- __le16 word = cpu_to_le16(get_unaligned((u16 *)val));
- return i2c_smbus_write_word_data(chip->client,
- reg << 1, (__force u16)word);
}
static int pca957x_write_regs_16(struct pca953x_chip *chip, int reg, u8 *val)
@@ -241,7 +238,6 @@ static int pca953x_read_regs_16(struct p
int ret;
ret = i2c_smbus_read_word_data(chip->client, reg << 1);
- val[0] = (u16)ret & 0xFF;
val[1] = (u16)ret >> 8;
return ret;
diff -u -p a/drivers/macintosh/windfarm_smu_sat.c b/drivers/macintosh/windfarm_smu_sat.c
--- a/drivers/macintosh/windfarm_smu_sat.c
+++ b/drivers/macintosh/windfarm_smu_sat.c
@@ -77,18 +77,15 @@ struct smu_sdbp_header *smu_sat_get_sdb_
return NULL;
}
- err = i2c_smbus_read_word_data(sat->i2c, 9);
if (err < 0) {
printk(KERN_ERR "smu_sat_get_sdb_part rd len error\n");
return NULL;
}
- len = err;
if (len == 0) {
printk(KERN_ERR "smu_sat_get_sdb_part no partition %x\n", id);
return NULL;
}
- len = le16_to_cpu(len);
len = (len + 3) & ~3;
buf = kmalloc(len, GFP_KERNEL);
if (buf == NULL)
diff -u -p a/drivers/macintosh/windfarm_lm75_sensor.c b/drivers/macintosh/windfarm_lm75_sensor.c
--- a/drivers/macintosh/windfarm_lm75_sensor.c
+++ b/drivers/macintosh/windfarm_lm75_sensor.c
@@ -68,7 +68,6 @@ static int wf_lm75_get(struct wf_sensor
}
/* Read temperature register */
- data = (s32)le16_to_cpu(i2c_smbus_read_word_data(lm->i2c, 0));
data <<= 8;
*value = data;
next prev parent reply other threads:[~2017-07-04 9:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-01 19:28 [PATCH] coccinelle: api: detect unnecessary le16_to_cpu Julia Lawall
2017-07-03 13:36 ` Sebastian Reichel
2017-07-03 16:37 ` Andy Shevchenko
2017-07-03 17:14 ` Sebastian Reichel
2017-07-03 17:33 ` Andy Shevchenko
2017-07-03 18:20 ` Sebastian Reichel
2017-07-04 9:11 ` Julia Lawall [this message]
2017-07-04 9:51 ` Andy Shevchenko
2017-07-04 9:53 ` Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1707041104390.3346@hadrien \
--to=julia.lawall@lip6.fr \
--cc=Gilles.Muller@lip6.fr \
--cc=andy.shevchenko@gmail.com \
--cc=benjamin.tissoires@redhat.com \
--cc=cocci@systeme.lip6.fr \
--cc=devel@acpica.org \
--cc=hadess@hadess.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=lv.zheng@intel.com \
--cc=mika.westerberg@linux.intel.com \
--cc=mmarek@suse.com \
--cc=nicolas.palix@imag.fr \
--cc=rafael.j.wysocki@intel.com \
--cc=robert.moore@intel.com \
--cc=sebastian.reichel@collabora.co.uk \
--cc=stephenjust@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).