From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752115AbdGGGrk (ORCPT <rfc822;w@1wt.eu>);
        Fri, 7 Jul 2017 02:47:40 -0400
Received: from Galois.linutronix.de ([146.0.238.70]:58921 "EHLO
        Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1750974AbdGGGrj (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 7 Jul 2017 02:47:39 -0400
Date: Fri, 7 Jul 2017 08:47:36 +0200 (CEST)
From: Thomas Gleixner <tglx@linutronix.de>
To: Shivappa Vikas <vikas.shivappa@intel.com>
cc: Vikas Shivappa <vikas.shivappa@linux.intel.com>, x86@kernel.org,
        linux-kernel@vger.kernel.org, hpa@zytor.com, peterz@infradead.org,
        ravi.v.shankar@intel.com, tony.luck@intel.com, fenghua.yu@intel.com,
        andi.kleen@intel.com
Subject: Re: [PATCH 19/21] x86/intel_rdt/mbm: Basic counting of MBM events
 (total and local)
In-Reply-To: <alpine.DEB.2.10.1707061637510.3798@vshiva-Udesk>
Message-ID: <alpine.DEB.2.20.1707070847010.1871@nanos>
References: <1498503368-20173-1-git-send-email-vikas.shivappa@linux.intel.com> <1498503368-20173-20-git-send-email-vikas.shivappa@linux.intel.com> <alpine.DEB.2.20.1707021543590.2296@nanos> <alpine.DEB.2.10.1707061637510.3798@vshiva-Udesk>
User-Agent: Alpine 2.20 (DEB 67 2015-01-07)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, 6 Jul 2017, Shivappa Vikas wrote:
> On Sun, 2 Jul 2017, Thomas Gleixner wrote:
> > >  	INIT_LIST_HEAD(&r->evt_list);
> > > 
> > >  	if (rdt_mon_features & (1 << QOS_L3_OCCUP_EVENT_ID))
> > >  		list_add_tail(&llc_occupancy_event.list, &r->evt_list);
> > > +	if (is_mbm_total_enabled())
> > > +		list_add_tail(&mbm_total_event.list, &r->evt_list);
> > > +	if (is_mbm_local_enabled())
> > > +		list_add_tail(&mbm_local_event.list, &r->evt_list);
> > 
> > Confused. This hooks all monitoring features to RDT_RESOURCE_L3. Why?
> 
> They are really L3 resource events as per the spec.
> CPUID.(EAX=0FH, ECX=0):EDX.L3[bit 1] = 1 if L3 monitoring and we query for all
> the llc_occupancy, l3 total and local b/w with the same resource id 1.

Then this should be documented somewhere in the code ....