From: Julia Lawall <julia.lawall@lip6.fr>
To: Pierre-Yves MORDRET <pierre-yves.mordret@st.com>
Cc: Vinod Koul <vinod.koul@intel.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Alexandre Torgue <alexandre.torgue@st.com>,
Russell King <linux@armlinux.org.uk>,
Dan Williams <dan.j.williams@intel.com>,
"M'boumba Cedric Madianga" <cedric.madianga@gmail.com>,
Fabrice GASNIER <fabrice.gasnier@st.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
Fabien DESSENNE <fabien.dessenne@st.com>,
Amelie Delaunay <amelie.delaunay@st.com>,
Pierre-Yves MORDRET <pierre-yves.mordret@st.com>,
dmaengine@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, kbuild-all@01.org
Subject: Re: [PATCH v2 2/4] dmaengine: Add STM32 MDMA driver (fwd)
Date: Sat, 8 Jul 2017 08:14:51 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.20.1707080813400.1971@hadrien> (raw)
Please check on the comparison on line 1489.
julia
---------- Forwarded message ----------
Date: Sat, 8 Jul 2017 10:13:09 +0800
From: kbuild test robot <fengguang.wu@intel.com>
To: kbuild@01.org
Cc: Julia Lawall <julia.lawall@lip6.fr>
Subject: Re: [PATCH v2 2/4] dmaengine: Add STM32 MDMA driver
Hi Pierre-Yves,
[auto build test WARNING on linus/master]
[also build test WARNING on v4.12 next-20170707]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Pierre-Yves-MORDRET/Add-STM32-MDMA-driver/20170708-013345
:::::: branch date: 9 hours ago
:::::: commit date: 9 hours ago
>> drivers/dma/stm32-mdma.c:1489:5-16: WARNING: Unsigned expression compared with zero: dmadev -> irq < 0
git remote add linux-review https://github.com/0day-ci/linux
git remote update linux-review
git checkout c6b3687d964d5a49aa0f297918bf26f6cb7444db
vim +1489 drivers/dma/stm32-mdma.c
c6b3687d Pierre-Yves MORDRET 2017-07-06 1473 BIT(DMA_SLAVE_BUSWIDTH_8_BYTES);
c6b3687d Pierre-Yves MORDRET 2017-07-06 1474 dd->directions = BIT(DMA_DEV_TO_MEM) | BIT(DMA_MEM_TO_DEV) |
c6b3687d Pierre-Yves MORDRET 2017-07-06 1475 BIT(DMA_MEM_TO_MEM);
c6b3687d Pierre-Yves MORDRET 2017-07-06 1476 dd->residue_granularity = DMA_RESIDUE_GRANULARITY_BURST;
c6b3687d Pierre-Yves MORDRET 2017-07-06 1477 dd->max_burst = STM32_MDMA_MAX_BURST;
c6b3687d Pierre-Yves MORDRET 2017-07-06 1478 dd->dev = &pdev->dev;
c6b3687d Pierre-Yves MORDRET 2017-07-06 1479 INIT_LIST_HEAD(&dd->channels);
c6b3687d Pierre-Yves MORDRET 2017-07-06 1480
c6b3687d Pierre-Yves MORDRET 2017-07-06 1481 for (i = 0; i < dmadev->nr_channels; i++) {
c6b3687d Pierre-Yves MORDRET 2017-07-06 1482 chan = &dmadev->chan[i];
c6b3687d Pierre-Yves MORDRET 2017-07-06 1483 chan->id = i;
c6b3687d Pierre-Yves MORDRET 2017-07-06 1484 chan->vchan.desc_free = stm32_mdma_desc_free;
c6b3687d Pierre-Yves MORDRET 2017-07-06 1485 vchan_init(&chan->vchan, dd);
c6b3687d Pierre-Yves MORDRET 2017-07-06 1486 }
c6b3687d Pierre-Yves MORDRET 2017-07-06 1487
c6b3687d Pierre-Yves MORDRET 2017-07-06 1488 dmadev->irq = platform_get_irq(pdev, 0);
c6b3687d Pierre-Yves MORDRET 2017-07-06 @1489 if (dmadev->irq < 0) {
c6b3687d Pierre-Yves MORDRET 2017-07-06 1490 dev_err(&pdev->dev, "failed to get IRQ\n");
c6b3687d Pierre-Yves MORDRET 2017-07-06 1491 return dmadev->irq;
c6b3687d Pierre-Yves MORDRET 2017-07-06 1492 }
c6b3687d Pierre-Yves MORDRET 2017-07-06 1493
c6b3687d Pierre-Yves MORDRET 2017-07-06 1494 ret = devm_request_irq(&pdev->dev, dmadev->irq, stm32_mdma_irq_handler,
c6b3687d Pierre-Yves MORDRET 2017-07-06 1495 0, dev_name(&pdev->dev), dmadev);
c6b3687d Pierre-Yves MORDRET 2017-07-06 1496 if (ret) {
c6b3687d Pierre-Yves MORDRET 2017-07-06 1497 dev_err(&pdev->dev, "failed to request IRQ\n");
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
next reply other threads:[~2017-07-08 6:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-08 6:14 Julia Lawall [this message]
2017-07-21 8:04 ` [PATCH v2 2/4] dmaengine: Add STM32 MDMA driver (fwd) Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1707080813400.1971@hadrien \
--to=julia.lawall@lip6.fr \
--cc=alexandre.torgue@st.com \
--cc=amelie.delaunay@st.com \
--cc=cedric.madianga@gmail.com \
--cc=dan.j.williams@intel.com \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=fabien.dessenne@st.com \
--cc=fabrice.gasnier@st.com \
--cc=herbert@gondor.apana.org.au \
--cc=kbuild-all@01.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=pierre-yves.mordret@st.com \
--cc=robh+dt@kernel.org \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).