From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755910AbdIGVp7 (ORCPT ); Thu, 7 Sep 2017 17:45:59 -0400 Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:8202 "EHLO mail2-relais-roc.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751456AbdIGVp6 (ORCPT ); Thu, 7 Sep 2017 17:45:58 -0400 X-IronPort-AV: E=Sophos;i="5.42,360,1500933600"; d="scan'208";a="290072714" Date: Thu, 7 Sep 2017 23:45:56 +0200 (CEST) From: Julia Lawall X-X-Sender: jll@hadrien To: harsha cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, outreachy-kernel@googlegroups.com Subject: Re: [Outreachy kernel] [PATCH] Staging:pi433:pi433_if.c:Fixes minor typo errors In-Reply-To: <1504816316-9331-1-git-send-email-harshasharmaiitr@gmail.com> Message-ID: References: <1504816316-9331-1-git-send-email-harshasharmaiitr@gmail.com> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 8 Sep 2017, harsha wrote: > Fixes checkpatch warning -- "occured" and "succesfully" are misspelled Thanks for the patch. The change looks ok, but the subject line is not. Use git log --oneline on the affected file to see what others have done. In general, you cannot guess what the subject line should be. But in almost all cases, there is a space after each : and a filename, if it needs to be included, does not have an extension. julia > > Signed-off-by: Harsha Sharma > --- > drivers/staging/pi433/pi433_if.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/staging/pi433/pi433_if.c > index 6b9b7df..6a10478 100644 > --- a/drivers/staging/pi433/pi433_if.c > +++ b/drivers/staging/pi433/pi433_if.c > @@ -473,7 +473,7 @@ struct pi433_instance { > } > > > - /* rx done, wait was interrupted or error occured */ > + /* rx done, wait was interrupted or error occurred */ > abort: > dev->interrupt_rx_allowed = true; > SET_CHECKED(rf69_set_mode(dev->spi, standby)); > @@ -1033,7 +1033,7 @@ static int setup_GPIOs(struct pi433_device *device) > if (retval) > return retval; > > - dev_dbg(&device->spi->dev, "%s succesfully configured", name); > + dev_dbg(&device->spi->dev, "%s successfully configured", name); > } > > return 0; > -- > 1.9.1 > > -- > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group. > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com. > To post to this group, send email to outreachy-kernel@googlegroups.com. > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/1504816316-9331-1-git-send-email-harshasharmaiitr%40gmail.com. > For more options, visit https://groups.google.com/d/optout. >