From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751471AbdIMSF0 (ORCPT ); Wed, 13 Sep 2017 14:05:26 -0400 Received: from Galois.linutronix.de ([146.0.238.70]:39470 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751106AbdIMSFW (ORCPT ); Wed, 13 Sep 2017 14:05:22 -0400 Date: Wed, 13 Sep 2017 20:05:18 +0200 (CEST) From: Thomas Gleixner To: Don Zickus cc: LKML , Ingo Molnar , Peter Zijlstra , Borislav Petkov , Andrew Morton , Sebastian Siewior , Nicholas Piggin , Chris Metcalf , Ulrich Obergfell Subject: Re: [patch V2 25/29] lockup_detector: Implement init time detection of perf In-Reply-To: <20170913180237.whri2g7soahd3ljl@redhat.com> Message-ID: References: <20170912193654.321505854@linutronix.de> <20170912194148.099799541@linutronix.de> <20170913180237.whri2g7soahd3ljl@redhat.com> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 13 Sep 2017, Don Zickus wrote: > > +/* Return 0, if a NMI watchdog is available. Error code otherwise */ > > +int __weak __init void watchdog_nmi_probe(void) > > ^^^ compile error, can't have 'int' and 'void'. Removing 'void' fixes it. Yes, I know. I feel stupid because I'm 100% sure that I compiled it ....