From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752193AbdJSJCA (ORCPT ); Thu, 19 Oct 2017 05:02:00 -0400 Received: from Galois.linutronix.de ([146.0.238.70]:60250 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751732AbdJSJB6 (ORCPT ); Thu, 19 Oct 2017 05:01:58 -0400 Date: Thu, 19 Oct 2017 11:01:56 +0200 (CEST) From: Thomas Gleixner To: Greg Kroah-Hartman cc: linux-usb@vger.kernel.org, LKML , Kate Stewart , Philippe Ombredanne , Linus Torvalds Subject: Re: [PATCH] USB: add SPDX identifiers to all files in drivers/usb/ In-Reply-To: <20171019085907.GA4044@kroah.com> Message-ID: References: <20171019083832.GA21820@kroah.com> <20171019085907.GA4044@kroah.com> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 19 Oct 2017, Greg Kroah-Hartman wrote: > On Thu, Oct 19, 2017 at 10:50:44AM +0200, Thomas Gleixner wrote: > > The last discussion about this was to add the identifier as the first line > > of the file or as the second in case of files with a shebang in the first > > one. > > > > I think you missed the last version of the script. Attached. > > Ugh, that's ugly, creating stuff like this: > > --- a/drivers/usb/atm/speedtch.c > +++ b/drivers/usb/atm/speedtch.c > @@ -1,3 +1,4 @@ > +// SPDX-License-Identifier: GPL-2.0+ > /****************************************************************************** > * speedtch.c - Alcatel SpeedTouch USB xDSL modem driver > * > diff --git a/drivers/usb/atm/ueagle-atm.c b/drivers/usb/atm/ueagle-atm.c > > > Are we really ok with the '//' comments? That's what Linus suggested so it stands out. Thanks, tglx