From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932376AbdJ0KBD (ORCPT ); Fri, 27 Oct 2017 06:01:03 -0400 Received: from resqmta-ch2-09v.sys.comcast.net ([69.252.207.41]:44264 "EHLO resqmta-ch2-09v.sys.comcast.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752258AbdJ0KA4 (ORCPT ); Fri, 27 Oct 2017 06:00:56 -0400 Date: Fri, 27 Oct 2017 05:00:54 -0500 (CDT) From: Christopher Lameter X-X-Sender: cl@nuc-kabylake To: Yang Shi cc: penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com, akpm@linux-foundation.org, mhocko@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] mm: extract common code for calculating total memory size In-Reply-To: <1508971740-118317-2-git-send-email-yang.s@alibaba-inc.com> Message-ID: References: <1508971740-118317-1-git-send-email-yang.s@alibaba-inc.com> <1508971740-118317-2-git-send-email-yang.s@alibaba-inc.com> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-CMAE-Envelope: MS4wfAXZ7tNZV/lKsp7M59HV00yF8fgOmKiSuuYoWa7NMZP60dmvfngPeS+NdYirR+lioEWgrv+MvLzBPbmXRcwZqZdRnVqOOIkGPtueeG2VoXzryhf/2xP6 IinZ+aLPKI2wDbAT1f8V/McxJH2ePKXz1enOvdUsR4y7fMcv4yYcOPu/v28ARNrHi6x7t3O/fSIlSoBLlM23kzEPoqWr+rz67JBr+roahC5hbLXDdEGsQyuX HVnE+0vNjkj2uV7lINBYgIp8dc/bItzWTl5JwtBInJggijlJMdc58gVQAhCMFxJtdHzlLSK6ixQCq25Hbiib+mi0KN4Zo1lLuecUuY7r523g5iq8ls2taNOE W8IXZJNcsADTHSbnNi3haMrxYiaZccWGufEDD+991dxAdcGnYfM= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 26 Oct 2017, Yang Shi wrote: > diff --git a/include/linux/mm.h b/include/linux/mm.h > index 935c4d4..e21b81e 100644 > --- a/include/linux/mm.h > +++ b/include/linux/mm.h > @@ -2050,6 +2050,31 @@ extern int __meminit __early_pfn_to_nid(unsigned long pfn, > static inline void zero_resv_unavail(void) {} > #endif > > +static inline void calc_mem_size(unsigned long *total, unsigned long *reserved, > + unsigned long *highmem) > +{ Huge incline function. This needs to go into mm/page_alloc.c or mm/slab_common.c