From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755080AbdKAR0d (ORCPT ); Wed, 1 Nov 2017 13:26:33 -0400 Received: from Galois.linutronix.de ([146.0.238.70]:50430 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754589AbdKAR0b (ORCPT ); Wed, 1 Nov 2017 13:26:31 -0400 Date: Wed, 1 Nov 2017 18:26:25 +0100 (CET) From: Thomas Gleixner To: Borislav Petkov cc: Andy Lutomirski , X86 ML , "linux-kernel@vger.kernel.org" , Brian Gerst , Dave Hansen , Linus Torvalds Subject: Re: [PATCH 07/18] x86/asm/64: Merge the fast and slow SYSRET paths In-Reply-To: <20171101123502.b7enfbablicdfujj@pd.tnic> Message-ID: References: <998a8c2c39546115f93e4c6e2ad7f918626f6145.1509006199.git.luto@kernel.org> <20171027201125.GD12039@nazgul.tnic> <20171101123502.b7enfbablicdfujj@pd.tnic> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 1 Nov 2017, Borislav Petkov wrote: > On Wed, Nov 01, 2017 at 04:29:21AM -0700, Andy Lutomirski wrote: > > I'm inclined to leave it. I first wrote it without the long name and > > then I had to re-read the code to make sure I got the register state > > right. The long name serves as documentation that we need rcx and r11 > > to have special contents. There's only one place that jumps there and > > it's in the same function. > > Frankly, I'd prefer a sane label name and a good comment over it instead > of insanely long label name which is not as explanatory as a normal > english sentence or two. Comments are always appreciated, but in that code really expressive labels make it way better to follow and prevent accidental wreckage. Thanks, tglx