From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752732AbdKHVy2 (ORCPT ); Wed, 8 Nov 2017 16:54:28 -0500 Received: from Galois.linutronix.de ([146.0.238.70]:48574 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751241AbdKHVy0 (ORCPT ); Wed, 8 Nov 2017 16:54:26 -0500 Date: Wed, 8 Nov 2017 22:54:23 +0100 (CET) From: Thomas Gleixner To: David Howells cc: keyrings@vger.kernel.org, linux-kernel@vger.kernel.org, linux-afs@lists.infradead.org Subject: Re: [PATCH 1/4] Add a function to start/reduce a timer In-Reply-To: <150937787256.31781.8531811303029438707.stgit@warthog.procyon.org.uk> Message-ID: References: <150937786557.31781.15521097996984061107.stgit@warthog.procyon.org.uk> <150937787256.31781.8531811303029438707.stgit@warthog.procyon.org.uk> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 30 Oct 2017, David Howells wrote: > Add a function, similar to mod_timer(), that will start a timer it isn't > running and will modify it if it is running and has an expiry time longer > than the new time. If the timer is running with an expiry time that's the > same or sooner, no change is made. > > The function looks like: > > int reduce_timer(struct timer_list *timer, unsigned long expires); It seems you missed to address any comment I made in: http://lkml.kernel.org/r/alpine.DEB.2.20.1710201359480.2908@nanos Thanks, tglx