From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752993AbdKWQmF (ORCPT <rfc822;w@1wt.eu>);
        Thu, 23 Nov 2017 11:42:05 -0500
Received: from Galois.linutronix.de ([146.0.238.70]:44134 "EHLO
        Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751982AbdKWQmE (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 23 Nov 2017 11:42:04 -0500
Date: Thu, 23 Nov 2017 17:41:58 +0100 (CET)
From: Thomas Gleixner <tglx@linutronix.de>
To: Andy Lutomirski <luto@kernel.org>
cc: Ingo Molnar <mingo@kernel.org>, X86 ML <x86@kernel.org>,
        Borislav Petkov <bpetkov@suse.de>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Brian Gerst <brgerst@gmail.com>, Dave Hansen <dave.hansen@intel.com>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Josh Poimboeuf <jpoimboe@redhat.com>
Subject: Re: [PATCH v2 00/18] Entry stack switching
In-Reply-To: <CALCETrXcUCtx5xFpMuNwacJxj1ktoWO=gso_C4dLd+JDAZBsvA@mail.gmail.com>
Message-ID: <alpine.DEB.2.20.1711231737290.1724@nanos>
References: <cover.1511325444.git.luto@kernel.org> <20171122062257.ivp5fbcy2k4mlfdm@gmail.com> <CALCETrVvpNVzixzAubip8-=8v=gE+Z_0CyXX117dmdbeXozEVQ@mail.gmail.com> <20171123062117.bztoxdqd2iv7ipdn@gmail.com> <20171123064414.hg7etp7iiis54ira@gmail.com>
 <20171123065828.dfzqe5cxfzlc2bcf@gmail.com> <CALCETrXcUCtx5xFpMuNwacJxj1ktoWO=gso_C4dLd+JDAZBsvA@mail.gmail.com>
User-Agent: Alpine 2.20 (DEB 67 2015-01-07)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, 23 Nov 2017, Andy Lutomirski wrote:
> On Wed, Nov 22, 2017 at 10:58 PM, Ingo Molnar <mingo@kernel.org> wrote:
> > * Ingo Molnar <mingo@kernel.org> wrote:
> >> * Ingo Molnar <mingo@kernel.org> wrote:
> >>
> >> > > Anyway, I booted your config (more or less -- I munged it through
> >> > > virtme-configkernel --update first) with 17 vCPUs and it seems fine.
> >> > > Is the issue reliable enough to bisect?
> >> >
> >> > Ok, it should be bisectable, will try to bisect it.
> >>
> >> The latestest entry-stack code appears to be working fine though.
> >>
> >> So one of the below fixes from yesterday appears to have done the trick.
> >>
> >> I'll re-test today to make sure: maybe it's more sporadic than I thought, in one
> >> of the bootups I got the do_IRQ warning only once, in half a day of uptime.
> >
> > I re-tested and it all seems fine now. I suspect it got fixed by:
> >
> >   ca37e57bbe0c: x86/entry/64: Add missing irqflags tracing to native_load_gs_index()
> >
> > still it is weird, because I boot that system with latest -tip on a daily basis,
> > and don't remember having seen that warning.
> >
> > Do you have any theory for why the entry stack changes would uncover this bug?
> 
> No.  I also don't see why it would have anything to do with irqflag
> tracing.  As far as I know, the unhandled IRQ warning has nothing to
> do with tracing or lockdep.

I suspect its more likely some subtle interaction with that newfangled
vector management code. You should poke the grumpy old greybeard.

Thanks,

	tglx