From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752179AbdK0NSw (ORCPT <rfc822;w@1wt.eu>);
        Mon, 27 Nov 2017 08:18:52 -0500
Received: from Galois.linutronix.de ([146.0.238.70]:55102 "EHLO
        Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752094AbdK0NSu (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 27 Nov 2017 08:18:50 -0500
Date: Mon, 27 Nov 2017 14:18:44 +0100 (CET)
From: Thomas Gleixner <tglx@linutronix.de>
To: Brian Gerst <brgerst@gmail.com>
cc: Peter Zijlstra <peterz@infradead.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        Andy Lutomirski <luto@kernel.org>, Ingo Molnar <mingo@kernel.org>,
        Borislav Petkov <bp@alien8.de>, Denys Vlasenko <dvlasenk@redhat.com>,
        "H. Peter Anvin" <hpa@zytor.com>, Josh Poimboeuf <jpoimboe@redhat.com>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Rik van Riel <riel@redhat.com>,
        Daniel Gruss <daniel.gruss@iaik.tugraz.at>,
        Hugh Dickins <hughd@google.com>, Kees Cook <keescook@google.com>,
        Linux-MM <linux-mm@kvack.org>, michael.schwarz@iaik.tugraz.at,
        moritz.lipp@iaik.tugraz.at, richard.fellner@student.tugraz.at
Subject: Re: [patch V2 1/5] x86/kaiser: Respect disabled CPU features
In-Reply-To: <CAMzpN2joDWU41SpNTu30pnOsZbdNcDMiCZ99HBy53SFVwvxMuw@mail.gmail.com>
Message-ID: <alpine.DEB.2.20.1711271416410.1799@nanos>
References: <20171126231403.657575796@linutronix.de> <20171126232414.313869499@linutronix.de> <20171127095737.ocolhqaxsaboycwa@hirez.programming.kicks-ass.net> <alpine.DEB.2.20.1711271241100.1799@nanos>
 <CAMzpN2joDWU41SpNTu30pnOsZbdNcDMiCZ99HBy53SFVwvxMuw@mail.gmail.com>
User-Agent: Alpine 2.20 (DEB 67 2015-01-07)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, 27 Nov 2017, Brian Gerst wrote:
> On Mon, Nov 27, 2017 at 6:47 AM, Thomas Gleixner <tglx@linutronix.de> wrote:
> > On Mon, 27 Nov 2017, Peter Zijlstra wrote:
> >> On Mon, Nov 27, 2017 at 12:14:04AM +0100, Thomas Gleixner wrote:
> >> > PAGE_NX and PAGE_GLOBAL might be not supported or disabled on the command
> >> > line, but KAISER sets them unconditionally.
> >>
> >> So KAISER is x86_64 only, right? AFAIK there is no x86_64 without NX
> >> support. So would it not make sense to mandate NX for KAISER?, that is
> >> instead of making "noexec" + KAISER work, make "noexec" kill KAISER +
> >> emit a warning.
> >
> > OTOH, disabling NX is a simple way to verify that DEBUG_WX works correctly
> > also on the shadow maps.
> >
> > But surely we can drop the PAGE_GLOBAL thing, as all 64bit systems have it.
> 
> I seem to recall that some virtualized environments (maybe Xen?) don't
> support global pages.

Uuurg. Ok, we leave it as is for now. Better safe than sorry. It does no
harm.

Thanks,

	tglx