From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755431AbdK2POa (ORCPT ); Wed, 29 Nov 2017 10:14:30 -0500 Received: from Galois.linutronix.de ([146.0.238.70]:39525 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751929AbdK2PO3 (ORCPT ); Wed, 29 Nov 2017 10:14:29 -0500 Date: Wed, 29 Nov 2017 16:14:12 +0100 (CET) From: Thomas Gleixner To: "Gustavo A. R. Silva" cc: Alan Cox , Ingo Molnar , "H. Peter Anvin" , x86@kernel.org, LKML , Kees Cook Subject: Re: [PATCH] x86/syscalls: Mark expected switch fall-throughs In-Reply-To: <20171129091050.Horde.2q2U63NpkxZnJ2HEQ6hKGaB@gator4166.hostgator.com> Message-ID: References: <20171127235253.GA20384@embeddedor.com> <20171128120512.Horde.1mz61Up1PsNtyHbrjWmK8L7@gator4166.hostgator.com> <20171128122235.Horde.vFP-9ZfAP0f9BFNePB8Z8xi@gator4166.hostgator.com> <20171128190032.2b1fa464@alans-desktop> <20171128142532.Horde.i2oBtHDOaD7XV1M3yAL7rga@gator4166.hostgator.com> <20171129091050.Horde.2q2U63NpkxZnJ2HEQ6hKGaB@gator4166.hostgator.com> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 29 Nov 2017, Gustavo A. R. Silva wrote: > Quoting Thomas Gleixner : > > > > > So I have to ask WHY this information was not in the changelog of the patch > > in question: > > > > 1) How it works > > > > 2) Why comments have been chosen over macros > > > > I will add this info and send the patch again. > > > > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > > > where we are expecting to fall through. > > > > It's not a reviewers job to chase that information down. > > > > While I can understand that the comments are intentional due to existing > > tools, I still prefer the macro/annotation. But I'm not religious about it > > when there is common consensus. :) ^^^^^^^^^^^^^^^^ This is the important point. And there are people aside of me who prefer the macro annotation. Thanks, tglx