From: Thomas Gleixner <tglx@linutronix.de>
To: Andy Lutomirski <luto@kernel.org>
Cc: X86 ML <x86@kernel.org>,
Jarkko Nikula <jarkko.nikula@linux.intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Borislav Petkov <bp@alien8.de>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH] x86/power: Fix some ordering bugs in __restore_processor_context()
Date: Thu, 30 Nov 2017 17:00:52 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.2.20.1711301700260.1925@nanos> (raw)
In-Reply-To: <CALCETrWdx7yRcKu3svcrQczjyGy_oXgjc9NcHbf_Bba9psKETw@mail.gmail.com>
On Thu, 30 Nov 2017, Andy Lutomirski wrote:
> On Thu, Nov 30, 2017 at 7:57 AM, Andy Lutomirski <luto@kernel.org> wrote:
> > __restore_processor_context() had a couple of ordering bugs. It
> > restored GSBASE after calling load_gs_index(), and the latter can
> > call into tracing code. It also tried to restore segment registers
> > before restoring the LDT, which is straight-up wrong.
>
> Ingo, Thomas, if you apply this version, can you fix up the following
> changelog bug:
>
> > .seg_not_present = 1,
>
> That should be = 0 above.
Sure. I'll wait for Jarkko to confirm.
> If I send a v2, I'll fix it.
>
next prev parent reply other threads:[~2017-11-30 16:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-30 15:57 [PATCH] x86/power: Fix some ordering bugs in __restore_processor_context() Andy Lutomirski
2017-11-30 15:59 ` Andy Lutomirski
2017-11-30 16:00 ` Thomas Gleixner [this message]
2017-12-01 9:06 ` Jarkko Nikula
2017-12-04 22:45 ` [tip:x86/urgent] " tip-bot for Andy Lutomirski
2017-12-06 11:36 ` tip-bot for Andy Lutomirski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1711301700260.1925@nanos \
--to=tglx@linutronix.de \
--cc=a.p.zijlstra@chello.nl \
--cc=bp@alien8.de \
--cc=jarkko.nikula@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).