From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752514AbdLDWvK (ORCPT <rfc822;w@1wt.eu>);
        Mon, 4 Dec 2017 17:51:10 -0500
Received: from Galois.linutronix.de ([146.0.238.70]:34294 "EHLO
        Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751711AbdLDWvH (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 4 Dec 2017 17:51:07 -0500
Date: Mon, 4 Dec 2017 23:51:00 +0100 (CET)
From: Thomas Gleixner <tglx@linutronix.de>
To: Andy Lutomirski <luto@kernel.org>
cc: LKML <linux-kernel@vger.kernel.org>, X86 ML <x86@kernel.org>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Peter Zijlstra <peterz@infradead.org>,
        Dave Hansen <dave.hansen@intel.com>, Borislav Petkov <bpetkov@suse.de>,
        Greg KH <gregkh@linuxfoundation.org>, Kees Cook <keescook@google.com>,
        Hugh Dickins <hughd@google.com>, Brian Gerst <brgerst@gmail.com>,
        Josh Poimboeuf <jpoimboe@redhat.com>,
        Denys Vlasenko <dvlasenk@redhat.com>, Rik van Riel <riel@redhat.com>,
        Boris Ostrovsky <boris.ostrovsky@oracle.com>,
        Juergen Gross <jgross@suse.com>,
        David Laight <David.Laight@aculab.com>,
        Eduardo Valentin <eduval@amazon.com>, aliguori@amazon.com,
        Will Deacon <will.deacon@arm.com>,
        Daniel Gruss <daniel.gruss@iaik.tugraz.at>
Subject: Re: [patch 47/60] x86/ldt: Map LDT entries into fixmap
In-Reply-To: <CALCETrWQ+nFKP3m8xQOnn53832kpBaqD7yNn256CfwNgx=J=PA@mail.gmail.com>
Message-ID: <alpine.DEB.2.20.1712042347320.2198@nanos>
References: <20171204140706.296109558@linutronix.de> <20171204150608.674502245@linutronix.de> <CALCETrWQ+nFKP3m8xQOnn53832kpBaqD7yNn256CfwNgx=J=PA@mail.gmail.com>
User-Agent: Alpine 2.20 (DEB 67 2015-01-07)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
X-Linutronix-Spam-Score: -1.0
X-Linutronix-Spam-Level: -
X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required,  ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, 4 Dec 2017, Andy Lutomirski wrote:

> On Mon, Dec 4, 2017 at 6:07 AM, Thomas Gleixner <tglx@linutronix.de> wrote:
> > From: Thomas Gleixner <tglx@linutronix.de>
> >
> > LDT is not really commonly used on 64bit so the overhead of populating the
> > fixmap entries on context switch for the rare LDT syscall users is a
> > reasonable trade off vs. having extra dynamically managed mapping space per
> > process.
> >
> 
> Hmm, I wonder just how slow this is.  It might be okay.  It's
> certainly not the way I imagined it working.

I know, it was the laziest way I could come up with. The only nasty thing
here is that __set_fixmap() does a tlb flush which is pointless as that
happens anyway. On my todo list was a noflush variant for set_fixmap along
with a variant which takes a whole range. That would simplify other places
as well. Though with the plan to map that stuff to a different place we
actually can avoid the weirdness of fixmaps

Thanks,

	tglx