From: Thomas Gleixner <tglx@linutronix.de>
To: Matthew Auld <matthew.auld@intel.com>
Cc: intel-gfx@lists.freedesktop.org,
"Joonas Lahtinen" <joonas.lahtinen@linux.intel.com>,
"Ville Syrjälä" <ville.syrjala@linux.intel.com>,
"Chris Wilson" <chris@chris-wilson.co.uk>,
"Paulo Zanoni" <paulo.r.zanoni@intel.com>,
"Ingo Molnar" <mingo@kernel.org>,
"H . Peter Anvin" <hpa@zytor.com>,
x86@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/9] x86/early-quirks: Extend Intel graphics stolen memory placement to 64bit
Date: Fri, 8 Dec 2017 23:58:21 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.2.20.1712082352250.2301@nanos> (raw)
In-Reply-To: <20171207122839.29925-2-matthew.auld@intel.com>
Matthew,
On Thu, 7 Dec 2017, Matthew Auld wrote:
Can you please add a version number to your patches? Having the same
subject line five times is just annoying.
> From: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> To give upcoming SKU BIOSes more flexibility in placing the Intel
> graphics stolen memory, make all variables storing the placement or size
> compatible with full 64 bit range. Also by exporting the stolen region
> as a resource, we can then nuke the duplicated stolen discovery in i915.
>
> v2: export the stolen region as a resource
> fix u16 << 16 (Chris)
> v3: actually fix u16 << 16
And please move the version thing below the --- separator so it can be
discarded by tools. It's not part of the changelog.
> +struct resource intel_graphics_stolen_res = DEFINE_RES_MEM(0, 0);
This is updated in __init so the variable should be marked __ro_after_init.
Thanks,
tglx
next prev parent reply other threads:[~2017-12-08 22:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20171207122839.29925-1-matthew.auld@intel.com>
2017-12-07 12:28 ` [PATCH 1/9] x86/early-quirks: Extend Intel graphics stolen memory placement to 64bit Matthew Auld
2017-12-08 22:58 ` Thomas Gleixner [this message]
2017-12-07 12:28 ` [PATCH 2/9] x86/early-quirks: replace the magical increment start values Matthew Auld
2017-12-07 12:28 ` [PATCH 3/9] x86/early-quirks: reverse the if ladders Matthew Auld
2017-12-08 23:05 ` Thomas Gleixner
[not found] <20171205210249.8875-1-matthew.auld@intel.com>
2017-12-05 21:02 ` [PATCH 1/9] x86/early-quirks: Extend Intel graphics stolen memory placement to 64bit Matthew Auld
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1712082352250.2301@nanos \
--to=tglx@linutronix.de \
--cc=chris@chris-wilson.co.uk \
--cc=hpa@zytor.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=joonas.lahtinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew.auld@intel.com \
--cc=mingo@kernel.org \
--cc=paulo.r.zanoni@intel.com \
--cc=ville.syrjala@linux.intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).