From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754075AbdLQLlr (ORCPT ); Sun, 17 Dec 2017 06:41:47 -0500 Received: from Galois.linutronix.de ([146.0.238.70]:43098 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752115AbdLQLlp (ORCPT ); Sun, 17 Dec 2017 06:41:45 -0500 Date: Sun, 17 Dec 2017 12:41:42 +0100 (CET) From: Thomas Gleixner To: Andy Lutomirski cc: Ingo Molnar , Linus Torvalds , "linux-kernel@vger.kernel.org" , "H. Peter Anvin" , Peter Zijlstra , Andrew Morton , Josh Poimboeuf , Borislav Petkov Subject: Re: [GIT PULL] x86 fixes In-Reply-To: Message-ID: References: <20171215154308.ixj3wwvy2gajmtpn@gmail.com> <20171215160735.p47cymimxcezfds7@gmail.com> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 16 Dec 2017, Andy Lutomirski wrote: > On Fri, Dec 15, 2017 at 8:07 AM, Ingo Molnar wrote: > I few things I noticed in the PTI tree: > > "x86/mm/pti: Map ESPFIX into user space" has a leftover pr_err(). > Sorry, my bad, I've spent *way* too long looking at this crap to > retain my sanity. Also, if you're feeling like being super tidy, the > init/main.c change in their could be folded in to whatever patch adds > pti_init() in the first place, but it doesn't really matter. I split it out into a separate patch and got rid of all the ifdef mess while at it. > "x86/pti: Map the vsyscall page if needed" has a change to > pgtable_64.h that could be folded into an earlier patch. This is > probably my fault for applying Dave Hansen's cleanup request to the > wrong patch. Done > "x86/mm/64: Make a full PGD-entry size hole in the memory map" would > benefit from a mention of "5-level" somewhere in the subject or > changelog. Will do > In "x86/fixmap: Add debugstore entries to cpu_entry_area", I think the > function "set_percpu_fixmap_ptes" is misnamed. It should be something > like "allocate_percpu_fixmap_ptes", perhaps, Ok. > and it should either warn > or do nothing if the PTE is already present, I think. As it stands, > it's a wee bit dangerous. Well, it's not more dangerous than all the other fixmap stuff we are doing. The only difference is that it does not install a mapping, it just makes sure that the PTE page is populated. > X86_BUG_CPU_SECURE_MODE_PTI should be added to DISABLED_FEATURES or > DISABLED_BUGS or whatever if it's not configured in, which will reduce > bloat. Borislav, that's kind of up your alley, since I don't think > the appropriate mask even exists right now. Will have a look. Thanks, tglx