From: Thomas Gleixner <tglx@linutronix.de>
To: vcaputo@pengaru.com
Cc: Pavel Machek <pavel@ucw.cz>, linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: thinkpad x60: sound problems in 4.15-rc1 was Re: thinkpad x60: sound problems in 4.14.0-next-20171114
Date: Thu, 28 Dec 2017 11:41:45 +0100 (CET)
Message-ID: <alpine.DEB.2.20.1712281140440.1688@nanos> (raw)
In-Reply-To: <20171224161601.cu6kr74cfckfxkj3@shells.gnugeneration.com>
On Sun, 24 Dec 2017, vcaputo@pengaru.com wrote:
> On Sat, Dec 23, 2017 at 09:33:37PM +0100, Thomas Gleixner wrote:
> > > It seems like the affinity changes are assuming a strict adherence to
> > > the CPU mask when the underlying hardware is treating it more as a hint.
> > > Perhaps handlers still need to be maintained on all CPUs in a given apic
> > > domain, regardless of what the masks are configured as, to cover these
> > > situations.
> >
> > That's odd. I'll have a look after the holidays.
> >
>
> Ok, just FYI I've reproduced it on rc5 as well.
>
> I may be offline a bit at the start of the new year, in case you've got
> something for me to test and I'm unresponsive.
Can you try the patch below?
Thanks,
tglx
8<---------------
--- a/arch/x86/kernel/apic/apic_flat_64.c
+++ b/arch/x86/kernel/apic/apic_flat_64.c
@@ -151,7 +151,7 @@ static struct apic apic_flat __ro_after_
.apic_id_valid = default_apic_id_valid,
.apic_id_registered = flat_apic_id_registered,
- .irq_delivery_mode = dest_LowestPrio,
+ .irq_delivery_mode = dest_Fixed,
.irq_dest_mode = 1, /* logical */
.disable_esr = 0,
--- a/arch/x86/kernel/apic/probe_32.c
+++ b/arch/x86/kernel/apic/probe_32.c
@@ -105,7 +105,7 @@ static struct apic apic_default __ro_aft
.apic_id_valid = default_apic_id_valid,
.apic_id_registered = default_apic_id_registered,
- .irq_delivery_mode = dest_LowestPrio,
+ .irq_delivery_mode = dest_Fixed,
/* logical delivery broadcast to all CPUs: */
.irq_dest_mode = 1,
--- a/arch/x86/kernel/apic/x2apic_cluster.c
+++ b/arch/x86/kernel/apic/x2apic_cluster.c
@@ -184,7 +184,7 @@ static struct apic apic_x2apic_cluster _
.apic_id_valid = x2apic_apic_id_valid,
.apic_id_registered = x2apic_apic_id_registered,
- .irq_delivery_mode = dest_LowestPrio,
+ .irq_delivery_mode = dest_Fixed,
.irq_dest_mode = 1, /* logical */
.disable_esr = 0,
next prev parent reply index
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-15 10:05 Pavel Machek
2017-11-15 10:43 ` Takashi Iwai
2017-11-15 11:11 ` Pavel Machek
2017-11-15 11:14 ` Takashi Iwai
2017-11-20 23:25 ` Pavel Machek
2017-11-27 16:30 ` thinkpad x60: sound problems in 4.15-rc1 was " Pavel Machek
2017-11-27 16:33 ` Takashi Iwai
2017-11-27 18:31 ` Pavel Machek
2017-11-27 18:35 ` Takashi Iwai
2017-11-27 18:44 ` Pavel Machek
2017-11-28 7:00 ` Takashi Iwai
2017-12-14 9:57 ` Pavel Machek
2017-12-19 2:06 ` vcaputo
2017-12-19 4:54 ` vcaputo
2017-12-19 23:12 ` vcaputo
2017-12-19 23:22 ` Pavel Machek
2017-12-20 0:36 ` vcaputo
2017-12-20 0:33 ` Thomas Gleixner
2017-12-20 0:59 ` vcaputo
2017-12-23 5:37 ` vcaputo
2017-12-23 20:37 ` vcaputo
2017-12-23 20:33 ` Thomas Gleixner
2017-12-24 16:16 ` vcaputo
2017-12-28 10:41 ` Thomas Gleixner [this message]
2017-12-28 18:30 ` vcaputo
2017-12-28 23:24 ` [tip:x86/urgent] x86/apic: Switch all APICs to Fixed delivery mode tip-bot for Thomas Gleixner
2017-12-29 13:31 ` tip-bot for Thomas Gleixner
2017-12-29 13:35 ` Thomas Gleixner
2017-12-25 10:12 ` thinkpad x60: sound problems in 4.15-rc1 was Re: thinkpad x60: sound problems in 4.14.0-next-20171114 Pavel Machek
2017-12-25 10:09 ` Pavel Machek
2018-01-02 20:54 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1712281140440.1688@nanos \
--to=tglx@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=vcaputo@pengaru.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
LKML Archive on lore.kernel.org
Archives are clonable:
git clone --mirror https://lore.kernel.org/lkml/0 lkml/git/0.git
git clone --mirror https://lore.kernel.org/lkml/1 lkml/git/1.git
git clone --mirror https://lore.kernel.org/lkml/2 lkml/git/2.git
git clone --mirror https://lore.kernel.org/lkml/3 lkml/git/3.git
git clone --mirror https://lore.kernel.org/lkml/4 lkml/git/4.git
git clone --mirror https://lore.kernel.org/lkml/5 lkml/git/5.git
git clone --mirror https://lore.kernel.org/lkml/6 lkml/git/6.git
git clone --mirror https://lore.kernel.org/lkml/7 lkml/git/7.git
git clone --mirror https://lore.kernel.org/lkml/8 lkml/git/8.git
git clone --mirror https://lore.kernel.org/lkml/9 lkml/git/9.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 lkml lkml/ https://lore.kernel.org/lkml \
linux-kernel@vger.kernel.org
public-inbox-index lkml
Example config snippet for mirrors
Newsgroup available over NNTP:
nntp://nntp.lore.kernel.org/org.kernel.vger.linux-kernel
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git