From: Julia Lawall <julia.lawall@lip6.fr>
To: Himanshu Jha <himanshujha199640@gmail.com>
Cc: yamada.masahiro@socionext.com, Julia.Lawall@lip6.fr,
Gilles Muller <Gilles.Muller@lip6.fr>,
nicolas.palix@imag.fr, michal.lkml@markovi.net,
cocci@systeme.lip6.fr, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Coccinelle: ifnullfree: Trim the warning reported in report mode
Date: Sat, 13 Jan 2018 17:28:07 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.2.20.1801131727520.3470@hadrien> (raw)
In-Reply-To: <1515859095-31824-1-git-send-email-himanshujha199640@gmail.com>
On Sat, 13 Jan 2018, Himanshu Jha wrote:
> Remove the unncessary part of the warning reported, in the report
> mode, so that a single warning produced does not exceed more than line
> and hence improve readability of the warnings produced in the subsequent
> reports to a file.
>
> Signed-off-by: Himanshu Jha <himanshujha199640@gmail.com>
Acked-by: Julia Lawall <julia.lawall@lip6.fr>
> ---
> scripts/coccinelle/free/ifnullfree.cocci | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/coccinelle/free/ifnullfree.cocci b/scripts/coccinelle/free/ifnullfree.cocci
> index 14a4cd9..a70e123 100644
> --- a/scripts/coccinelle/free/ifnullfree.cocci
> +++ b/scripts/coccinelle/free/ifnullfree.cocci
> @@ -55,5 +55,5 @@ cocci.print_main("NULL check before that freeing function is not needed", p)
> p << r.p;
> @@
>
> -msg = "WARNING: NULL check before freeing functions like kfree, debugfs_remove, debugfs_remove_recursive or usb_free_urb is not needed. Maybe consider reorganizing relevant code to avoid passing NULL values."
> +msg = "WARNING: NULL check before some freeing functions is not needed."
> coccilib.report.print_report(p[0], msg)
> --
> 2.7.4
>
>
next prev parent reply other threads:[~2018-01-13 16:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-13 15:58 [PATCH] Coccinelle: ifnullfree: Trim the warning reported in report mode Himanshu Jha
2018-01-13 16:28 ` Julia Lawall [this message]
2018-01-16 14:34 ` Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1801131727520.3470@hadrien \
--to=julia.lawall@lip6.fr \
--cc=Gilles.Muller@lip6.fr \
--cc=cocci@systeme.lip6.fr \
--cc=himanshujha199640@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.lkml@markovi.net \
--cc=nicolas.palix@imag.fr \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).