From: Thomas Gleixner <tglx@linutronix.de>
To: David Howells <dhowells@redhat.com>
Cc: linux-arch@vger.kernel.org, x86@kernel.org,
linux-ia64@vger.kernel.org, torvalds@linux-foundation.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/5] Expand the INIT_SIGNALS and INIT_SIGHAND macros and remove
Date: Wed, 17 Jan 2018 12:14:50 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.2.20.1801171214120.1777@nanos> (raw)
In-Reply-To: <19929.1514903630@warthog.procyon.org.uk>
On Tue, 2 Jan 2018, David Howells wrote:
> Thomas Gleixner <tglx@linutronix.de> wrote:
>
> > > #define INIT_CPU_TIMERS(s) \
> > ...
> > That macro is only used in init_task.c Why not moving it there and get rid
> > of the whole macro maze in the header file?
>
> The reason I didn't get rid of it is that it's got more than one expansion
> point. Same for INIT_PREV_CPUTIME and INIT_PID_LINK.
Ah, sorry I missed that. So yes, the current patch is fine.
Acked-by: Thomas Gleixner <tglx@linutronix.de>
next prev parent reply other threads:[~2018-01-17 11:14 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-08 15:51 [PATCH 0/5] Consolidate init_task handling and expand macros David Howells
2017-12-08 15:51 ` [PATCH 1/5] Construct init thread stack in the linker script rather than by union David Howells
2017-12-08 15:51 ` [PATCH 2/5] Expand INIT_TASK() in init/init_task.c and remove David Howells
2017-12-08 15:51 ` [PATCH 3/5] Expand various INIT_* macros " David Howells
2017-12-08 15:51 ` [PATCH 4/5] Expand the INIT_SIGNALS and INIT_SIGHAND " David Howells
2017-12-28 15:04 ` Thomas Gleixner
2018-01-02 14:33 ` David Howells
2018-01-17 11:14 ` Thomas Gleixner [this message]
2017-12-08 15:51 ` [PATCH 5/5] Expand INIT_STRUCT_PID " David Howells
2017-12-08 15:54 ` Does this break IA64 Linux? David Howells
2017-12-08 18:30 ` Luck, Tony
2017-12-08 19:04 ` David Howells
2017-12-08 22:14 ` Luck, Tony
2017-12-08 22:24 ` David Howells
2017-12-08 22:33 ` Luck, Tony
2017-12-08 15:56 ` Adding init_task consolidation patches to linux-next David Howells
2017-12-10 20:08 ` Stephen Rothwell
2017-12-14 18:21 ` David Howells
2017-12-14 18:32 ` Palmer Dabbelt
2017-12-15 8:36 ` David Howells
2017-12-15 18:52 ` Palmer Dabbelt
2017-12-15 2:49 ` Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1801171214120.1777@nanos \
--to=tglx@linutronix.de \
--cc=dhowells@redhat.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).