From: Julia Lawall <julia.lawall@lip6.fr>
To: Gabriel Francisco Mandaji <gfmandaji@gmail.com>
Cc: devel@driverdev.osuosl.org, gregkh@linuxfoundation.org,
linux-kernel@vger.kernel.org, abbotti@mev.co.uk,
lkcamp@lists.libreplanetbr.org
Subject: Re: [PATCH] staging: comedi: cb_pcidas64: fix alignment of function parameters
Date: Wed, 11 Apr 2018 07:07:51 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.20.1804110707130.2316@hadrien> (raw)
In-Reply-To: <20180410225007.GA5050@gfm-note>
On Tue, 10 Apr 2018, Gabriel Francisco Mandaji wrote:
> Fix most checkpatch.pl issues of type:
>
> CHECK: Alignment should match open parenthesis
>
> Signed-off-by: Gabriel Francisco Mandaji <gfmandaji@gmail.com>
> ---
> drivers/staging/comedi/drivers/cb_pcidas64.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/comedi/drivers/cb_pcidas64.c b/drivers/staging/comedi/drivers/cb_pcidas64.c
> index fdd81c3..631a703 100644
> --- a/drivers/staging/comedi/drivers/cb_pcidas64.c
> +++ b/drivers/staging/comedi/drivers/cb_pcidas64.c
> @@ -2268,14 +2268,14 @@ static inline unsigned int dma_transfer_size(struct comedi_device *dev)
> }
>
> static u32 ai_convert_counter_6xxx(const struct comedi_device *dev,
> - const struct comedi_cmd *cmd)
> + const struct comedi_cmd *cmd)
Someone has made the effort to put const on these parameters, but not on
the other similar functions. Perhaps this can be improved as well.
julia
> {
> /* supposed to load counter with desired divisor minus 3 */
> return cmd->convert_arg / TIMER_BASE - 3;
> }
>
> static u32 ai_scan_counter_6xxx(struct comedi_device *dev,
> - struct comedi_cmd *cmd)
> + struct comedi_cmd *cmd)
> {
> u32 count;
>
> @@ -2296,7 +2296,7 @@ static u32 ai_scan_counter_6xxx(struct comedi_device *dev,
> }
>
> static u32 ai_convert_counter_4020(struct comedi_device *dev,
> - struct comedi_cmd *cmd)
> + struct comedi_cmd *cmd)
> {
> struct pcidas64_private *devpriv = dev->private;
> unsigned int divisor;
> --
> 1.9.1
>
>
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
next prev parent reply other threads:[~2018-04-11 5:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-10 22:50 [PATCH] staging: comedi: cb_pcidas64: fix alignment of function parameters Gabriel Francisco Mandaji
2018-04-11 5:07 ` Julia Lawall [this message]
2018-04-11 9:16 ` Ian Abbott
2018-04-11 9:18 ` Ian Abbott
2018-04-12 23:04 ` Gabriel Francisco Mandaji
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1804110707130.2316@hadrien \
--to=julia.lawall@lip6.fr \
--cc=abbotti@mev.co.uk \
--cc=devel@driverdev.osuosl.org \
--cc=gfmandaji@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkcamp@lists.libreplanetbr.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).