From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 78B0AC46460 for ; Tue, 14 Aug 2018 10:58:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 395ED21778 for ; Tue, 14 Aug 2018 10:58:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 395ED21778 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lip6.fr Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731105AbeHNNor (ORCPT ); Tue, 14 Aug 2018 09:44:47 -0400 Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:62619 "EHLO mail2-relais-roc.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727858AbeHNNor (ORCPT ); Tue, 14 Aug 2018 09:44:47 -0400 X-IronPort-AV: E=Sophos;i="5.53,238,1531778400"; d="scan'208";a="342429575" Received: from vaio-julia.rsr.lip6.fr ([132.227.76.33]) by mail2-relais-roc.national.inria.fr with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 14 Aug 2018 12:58:06 +0200 Date: Tue, 14 Aug 2018 12:57:57 +0200 (CEST) From: Julia Lawall X-X-Sender: jll@hadrien To: Wu Zhigang cc: kbuild-all@01.org, sof-ci-monitor@eclists.intel.com, Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Ranjani Sridharan , Rander Wang , Pan Xiuli , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: [PATCH] fix ifnullfree.cocci warnings Message-ID: User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: kbuild test robot NULL check before some freeing functions is not needed. Based on checkpatch warning "kfree(NULL) is safe this check is probably not required" and kfreeaddr.cocci by Julia Lawall. Generated by: scripts/coccinelle/free/ifnullfree.cocci Fixes: 0099cc17a399 ("ASoC:topology:avoid error log and oops during topology free.") Signed-off-by: kbuild test robot Signed-off-by: Julia Lawall --- Feel free to ignore this if the null test is useful in some way. topology.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) --- a/sound/soc/sof/topology.c +++ b/sound/soc/sof/topology.c @@ -2165,8 +2165,7 @@ void snd_sof_free_topology(struct snd_so /* free sroute and its private data */ kfree(sroute->route->source); kfree(sroute->route->sink); - if (sroute->route->control) - kfree(sroute->route->control); + kfree(sroute->route->control); kfree(sroute->route); kfree(sroute->private); kfree(sroute);