From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934895AbeBMQgl (ORCPT ); Tue, 13 Feb 2018 11:36:41 -0500 Received: from Galois.linutronix.de ([146.0.238.70]:51029 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934210AbeBMQgk (ORCPT ); Tue, 13 Feb 2018 11:36:40 -0500 Date: Tue, 13 Feb 2018 17:36:34 +0100 (CET) From: Thomas Gleixner To: Sebastian Andrzej Siewior cc: David Miller , edumazet@google.com, torvalds@linux-foundation.org, efault@gmx.de, peterz@infradead.org, dima@arista.com, frederic@kernel.org, linux-kernel@vger.kernel.org, 0x7f454c46@gmail.com, akpm@linux-foundation.org, fweisbec@gmail.com, hannes@stressinduktion.org, mingo@kernel.org, alexander.levin@verizon.com, pabeni@redhat.com, paulmck@linux.vnet.ibm.com, rrendec@arista.com, riel@redhat.com, sgruszka@redhat.com, wanpeng.li@hotmail.com Subject: Re: [RFC 1/2] softirq: Defer net rx/tx processing to ksoftirqd context In-Reply-To: <20180206165649.cze4iy4k36rcigbe@breakpoint.cc> Message-ID: References: <20180117.172447.1568697383040902713.davem@davemloft.net> <20180206165649.cze4iy4k36rcigbe@breakpoint.cc> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 6 Feb 2018, Sebastian Andrzej Siewior wrote: > On 2018-01-17 17:24:47 [-0500], David Miller wrote: > > From: Eric Dumazet > > Date: Wed, 17 Jan 2018 14:02:43 -0800 > > > There is also the netif_rx_ni() stuff. > > > > > > Can't remember right now why it is not using > > > local_bh_{diable,enable}() pair instead > > > of preempt_disable() ... if (local_softirq_pending()) do_softirq(); > > > > Hmmm, that code predates the initial GIT repository build. > > > > I do remember we had some back and forth with that stuff. > > So I did a little research and tried to replace preempt_disable() with > local_bh_disable() [0] a while ago. > > [0] https://lkml.kernel.org/r/20170616172400.10809-1-bigeasy@linutronix.de Maybe you should just try again with a slightly better changelog :)