From: Thomas Gleixner <tglx@linutronix.de>
To: Dave Hansen <dave.hansen@intel.com>
Cc: Shakeel Butt <shakeelb@google.com>,
Dave Hansen <dave.hansen@linux.intel.com>,
LKML <linux-kernel@vger.kernel.org>,
Linux MM <linux-mm@kvack.org>,
linuxram@us.ibm.com, mpe@ellerman.id.au,
Ingo Molnar <mingo@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
shuah@kernel.org
Subject: Re: [PATCH 4/9] x86, pkeys: override pkey when moving away from PROT_EXEC
Date: Fri, 23 Mar 2018 20:38:09 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.2.21.1803232036140.1481@nanos.tec.linutronix.de> (raw)
In-Reply-To: <f7897068-18a3-d88b-0458-5dcf05d7ffc2@intel.com>
On Fri, 23 Mar 2018, Dave Hansen wrote:
> On 03/23/2018 12:15 PM, Shakeel Butt wrote:
> >> We had a check for PROT_READ/WRITE, but it did not work
> >> for PROT_NONE. This entirely removes the PROT_* checks,
> >> which ensures that PROT_NONE now works.
> >>
> >> Reported-by: Shakeel Butt <shakeelb@google.com>
> >> Signed-off-by: Dave Hansen <dave.hansen@linux.intel.com>
> > Should there be a 'Fixes' tag? Also should this patch go to stable?
>
> There could be, but I'm to lazy to dig up the original commit. Does it
> matter?
>
> And, yes, I think it probably makes sense for -stable. I'll add that if
> I resend this series.
The fixes tag makes sense in general even if the patch is not tagged for
stable. It gives you immediate context and I use it a lot to look why this
went unnoticed or what the context of that change was.
Thanks,
tglx
next prev parent reply other threads:[~2018-03-23 19:38 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-23 18:09 [PATCH 0/9] x86, pkeys: two protection keys bug fixes Dave Hansen
2018-03-23 18:09 ` [PATCH 1/9] x86, pkeys: do not special case protection key 0 Dave Hansen
2018-03-26 17:35 ` Ram Pai
2018-03-26 17:39 ` Dave Hansen
2018-03-27 2:27 ` Ram Pai
2018-03-27 4:11 ` Dave Hansen
2018-03-23 18:09 ` [PATCH 2/9] x86, pkeys, selftests: save off 'prot' for allocations Dave Hansen
2018-03-23 18:09 ` [PATCH 3/9] x86, pkeys, selftests: add a test for pkey 0 Dave Hansen
2018-03-23 18:09 ` [PATCH 4/9] x86, pkeys: override pkey when moving away from PROT_EXEC Dave Hansen
2018-03-23 19:15 ` Shakeel Butt
2018-03-23 19:23 ` Dave Hansen
2018-03-23 19:27 ` Shakeel Butt
2018-03-23 19:29 ` Dave Hansen
2018-03-23 19:38 ` Thomas Gleixner [this message]
2018-03-23 19:45 ` Thomas Gleixner
2018-03-23 19:48 ` Dave Hansen
2018-03-23 18:09 ` [PATCH 5/9] x86, pkeys, selftests: fix pointer math Dave Hansen
2018-03-23 18:09 ` [PATCH 6/9] x86, pkeys, selftests: fix pkey exhaustion test off-by-one Dave Hansen
2018-03-23 18:09 ` [PATCH 7/9] x86, pkeys, selftests: factor out "instruction page" Dave Hansen
2018-03-23 18:09 ` [PATCH 8/9] x86, pkeys, selftests: add allow faults on unknown keys Dave Hansen
2018-03-23 18:09 ` [PATCH 9/9] x86, pkeys, selftests: add PROT_EXEC test Dave Hansen
2018-03-26 17:27 [PATCH 0/9] [v2] x86, pkeys: two protection keys bug fixes Dave Hansen
2018-03-26 17:27 ` [PATCH 4/9] x86, pkeys: override pkey when moving away from PROT_EXEC Dave Hansen
2018-04-07 0:09 ` Ram Pai
2018-04-07 0:47 ` Dave Hansen
2018-04-07 1:09 ` Ram Pai
2018-04-26 17:57 ` Dave Hansen
2018-04-30 7:51 ` Ram Pai
2018-04-30 16:36 ` Dave Hansen
2018-04-25 22:10 ` Shakeel Butt
2018-04-26 8:55 ` Thomas Gleixner
2018-04-26 18:17 ` Dave Hansen
2018-04-27 17:45 [PATCH 0/9] [v3] x86, pkeys: two protection keys bug fixes Dave Hansen
2018-04-27 17:45 ` [PATCH 4/9] x86, pkeys: override pkey when moving away from PROT_EXEC Dave Hansen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.1803232036140.1481@nanos.tec.linutronix.de \
--to=tglx@linutronix.de \
--cc=akpm@linux-foundation.org \
--cc=dave.hansen@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linuxram@us.ibm.com \
--cc=mingo@kernel.org \
--cc=mpe@ellerman.id.au \
--cc=shakeelb@google.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).