linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: linux-kernel@vger.kernel.org,
	Mike Galbraith <umgwanakikbuti@gmail.com>,
	x86@kernel.org, Mike Galbraith <mgalbraith@suse.de>
Subject: Re: [PATCH] x86: UV: raw_spinlock conversion
Date: Sun, 6 May 2018 12:26:54 +0200 (CEST)	[thread overview]
Message-ID: <alpine.DEB.2.21.1805061225550.1685@nanos.tec.linutronix.de> (raw)
In-Reply-To: <20180504111459.24825-2-bigeasy@linutronix.de>

On Fri, 4 May 2018, Sebastian Andrzej Siewior wrote:

> From: Mike Galbraith <umgwanakikbuti@gmail.com>
> 
> Shrug.  Lots of hobbyists have a beast in their basement, right?

This hardly qualifies as a proper changelog ...

>  }
> @@ -299,13 +299,17 @@ static int uv_rtc_unset_timer(int cpu, i
>  static u64 uv_read_rtc(struct clocksource *cs)
>  {
>  	unsigned long offset;
> +	u64 cycles;
>  
> +	preempt_disable();
>  	if (uv_get_min_hub_revision_id() == 1)
>  		offset = 0;
>  	else
>  		offset = (uv_blade_processor_id() * L1_CACHE_BYTES) % PAGE_SIZE;
>  
> -	return (u64)uv_read_local_mmr(UVH_RTC | offset);
> +	cycles = (u64)uv_read_local_mmr(UVH_RTC | offset);
> +	preempt_enable();
> +	return cycles;

And how exaclty is this hunk related?

Thanks,

	tglx

  reply	other threads:[~2018-05-06 10:27 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-04 11:14 [PATCH] x86: Convert mce timer to hrtimer Sebastian Andrzej Siewior
2018-05-04 11:14 ` [PATCH] x86: UV: raw_spinlock conversion Sebastian Andrzej Siewior
2018-05-06 10:26   ` Thomas Gleixner [this message]
2018-05-06 10:59     ` Mike Galbraith
2018-05-07  7:39       ` Sebastian Andrzej Siewior
2018-05-07  7:59         ` Mike Galbraith
2018-05-19 14:09         ` Mike Galbraith
2018-05-22  6:50           ` Sebastian Andrzej Siewior
2018-05-22  8:24             ` Mike Galbraith
2018-05-22  9:14               ` Sebastian Andrzej Siewior
2018-05-22  9:46                 ` Mike Galbraith
2018-05-22 12:48                   ` Mike Galbraith
2018-05-07  9:04 ` [PATCH] x86: Convert mce timer to hrtimer Sebastian Andrzej Siewior

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.21.1805061225550.1685@nanos.tec.linutronix.de \
    --to=tglx@linutronix.de \
    --cc=bigeasy@linutronix.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mgalbraith@suse.de \
    --cc=umgwanakikbuti@gmail.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).