linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: Mukesh Ojha <mojha@codeaurora.org>
Cc: john.stultz@linaro.org, linux-kernel@vger.kernel.org,
	neeraju@codeaurora.org, gkohli@codeaurora.org,
	cpandya@codeaurora.org
Subject: Re: [PATCH v2] time: Fix sleeptime injection for non-stop clocksource & persistent clock
Date: Mon, 25 Jun 2018 17:04:22 +0200 (CEST)	[thread overview]
Message-ID: <alpine.DEB.2.21.1806251701410.1821@nanos.tec.linutronix.de> (raw)
In-Reply-To: <e869c2ec-90fa-27e2-975c-a92469f56dac@codeaurora.org>

On Mon, 25 Jun 2018, Mukesh Ojha wrote:
> On 6/23/2018 2:57 AM, Thomas Gleixner wrote:
> > @@ -1671,7 +1685,6 @@ void timekeeping_resume(void)
> >   	struct timespec64 ts_new, ts_delta;
> >   	u64 cycle_now;
> >   -	sleeptime_injected = false;
> >   	read_persistent_clock64(&ts_new);
> >     	clockevents_resume();
> > @@ -1743,6 +1756,8 @@ int timekeeping_suspend(void)
> >   	if (timekeeping_suspend_time.tv_sec ||
> > timekeeping_suspend_time.tv_nsec)
> >   		persistent_clock_exists = true;
> >   +	sleeptime_injected = false;
> 
> I did not get the exact valid point of moving it from `timekeeping_suspend` to
> `timekeeping_resume`.

It's the other way round. I move it from resume to suspend. Simply because
it should only be set to 'false' when suspend is reached. It would work the
other way round as well, but I felt it's inconsistent.

Thanks,

	tglx



  reply	other threads:[~2018-06-25 15:04 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-30 11:44 [PATCH v2] time: Fix sleeptime injection for non-stop clocksource & persistent clock Mukesh Ojha
2018-06-14 14:07 ` Mukesh Ojha
2018-06-22 21:27 ` Thomas Gleixner
2018-06-25 14:38   ` Mukesh Ojha
2018-06-25 15:04     ` Thomas Gleixner [this message]
2018-07-06  8:15       ` Mukesh Ojha
2018-07-06  8:58         ` Thomas Gleixner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.21.1806251701410.1821@nanos.tec.linutronix.de \
    --to=tglx@linutronix.de \
    --cc=cpandya@codeaurora.org \
    --cc=gkohli@codeaurora.org \
    --cc=john.stultz@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mojha@codeaurora.org \
    --cc=neeraju@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).