From: David Rientjes <rientjes@google.com>
To: Michal Hocko <mhocko@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>,
linux-mm@kvack.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mm, oom: remove sleep from under oom_lock
Date: Tue, 10 Jul 2018 14:12:28 -0700 (PDT) [thread overview]
Message-ID: <alpine.DEB.2.21.1807101411480.29772@chino.kir.corp.google.com> (raw)
In-Reply-To: <alpine.DEB.2.21.1807101152410.9234@chino.kir.corp.google.com>
On Tue, 10 Jul 2018, David Rientjes wrote:
> I think it's better, thanks. However, does it address the question about
> why __oom_reap_task_mm() needs oom_lock protection? Perhaps it would be
> helpful to mention synchronization between reaping triggered from
> oom_reaper and by exit_mmap().
>
Actually, can't we remove the need to take oom_lock in exit_mmap() if
__oom_reap_task_mm() can do a test and set on MMF_UNSTABLE and, if already
set, bail out immediately?
next prev parent reply other threads:[~2018-07-10 21:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-09 7:47 [PATCH] mm, oom: remove sleep from under oom_lock Michal Hocko
2018-07-09 22:49 ` David Rientjes
2018-07-10 9:43 ` Michal Hocko
2018-07-10 18:55 ` David Rientjes
2018-07-10 21:12 ` David Rientjes [this message]
2018-07-11 8:59 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.1807101411480.29772@chino.kir.corp.google.com \
--to=rientjes@google.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=penguin-kernel@i-love.sakura.ne.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).