From: Thomas Gleixner <tglx@linutronix.de>
To: Mukesh Ojha <mojha@codeaurora.org>
Cc: John Stultz <john.stultz@linaro.org>,
lkml <linux-kernel@vger.kernel.org>,
gkohli@codeaurora.org, cpandya@codeaurora.org,
neeraju@codeaurora.org, Baolin Wang <baolin.wang@linaro.org>
Subject: Re: [PATCH v3] time: Fix incorrect sleeptime injection when suspend fails
Date: Mon, 16 Jul 2018 21:18:17 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.21.1807162116180.1693@nanos.tec.linutronix.de> (raw)
In-Reply-To: <19b10a21-2636-49a9-2a1a-488f293aeb45@codeaurora.org>
On Tue, 17 Jul 2018, Mukesh Ojha wrote:
> On 7/16/2018 10:44 PM, John Stultz wrote:
> > > So, I think with the logic bug above it will work out properly, but
> > > let me know if I'm still missing something.
>
> Please give it thought to a case where very first suspend fails with your
> logic.
> If i am not able to get your thought, please write a patch.
John wants you to invert the logic. i.e.
true -> false
false -> true
if (var) -> if (!var)
if (!var) -> if (var)
It's not that hard, right?
Thanks,
tglx
prev parent reply other threads:[~2018-07-16 19:18 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-06 13:17 [PATCH v3] time: Fix incorrect sleeptime injection when suspend fails Mukesh Ojha
2018-07-10 20:13 ` John Stultz
2018-07-13 7:13 ` Mukesh Ojha
2018-07-13 17:20 ` John Stultz
2018-07-16 16:17 ` Mukesh Ojha
2018-07-16 16:30 ` John Stultz
2018-07-16 17:14 ` John Stultz
2018-07-16 18:30 ` Mukesh Ojha
2018-07-16 18:54 ` John Stultz
2018-07-16 19:18 ` Thomas Gleixner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.1807162116180.1693@nanos.tec.linutronix.de \
--to=tglx@linutronix.de \
--cc=baolin.wang@linaro.org \
--cc=cpandya@codeaurora.org \
--cc=gkohli@codeaurora.org \
--cc=john.stultz@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mojha@codeaurora.org \
--cc=neeraju@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).