From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,T_DKIM_INVALID, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6FE60C43142 for ; Thu, 2 Aug 2018 19:30:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2AC1C2154D for ; Thu, 2 Aug 2018 19:30:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=pmeerw.net header.i=@pmeerw.net header.b="DODU3beD" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2AC1C2154D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=pmeerw.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727841AbeHBVWq (ORCPT ); Thu, 2 Aug 2018 17:22:46 -0400 Received: from ns.pmeerw.net ([84.19.176.117]:46362 "EHLO ns.pmeerw.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726268AbeHBVWp (ORCPT ); Thu, 2 Aug 2018 17:22:45 -0400 Received: by ns.pmeerw.net (Postfix, from userid 1000) id 67A37E0660; Thu, 2 Aug 2018 21:30:12 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=pmeerw.net; s=mail; t=1533238212; bh=n5qhf+rP1sCDz9EcqBhasVplETGdHLw/+JIJcDLOv0o=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=DODU3beDdNZpHOk6AxwPYRmw8As3ovQyDPX8RQqqowbIh3ARJdabWDvMXkwXdHWI8 szJHYA/xEsV0BkPfrQID696b+nvNcXdh2HJY7+DE729WOv/rp2bzs85+Iuf04vHnGF D28AVthdfxscpUmUpfCnnL0jouvLO41QRV3lPSfs= Received: from localhost (localhost [127.0.0.1]) by ns.pmeerw.net (Postfix) with ESMTP id 18064E01C1; Thu, 2 Aug 2018 21:30:12 +0200 (CEST) Date: Thu, 2 Aug 2018 21:30:12 +0200 (CEST) From: Peter Meerwald-Stadler To: Parthiban Nallathambi cc: jic23@kernel.org, knaack.h@gmx.de, lars@metafoo.de, robh+dt@kernel.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, mark.rutland@arm.com, devicetree@vger.kernel.org, matthias.bgg@gmail.com, wd@denx.de, sbabic@denx.de, hs@denx.de Subject: Re: [PATCH v4 1/3] iio: Add modifier for white light In-Reply-To: <20180802182729.2061830-1-pn@denx.de> Message-ID: References: <20180802182729.2061830-1-pn@denx.de> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, it is not clear to me why 'white' is needed; isn't that the default, i.e. unfiltered light? thanks, regards, p. > Signed-off-by: Parthiban Nallathambi > --- > Documentation/ABI/testing/sysfs-bus-iio | 7 +++++++ > drivers/iio/industrialio-core.c | 1 + > include/uapi/linux/iio/types.h | 1 + > tools/iio/iio_event_monitor.c | 2 ++ > 4 files changed, 11 insertions(+) > > diff --git a/Documentation/ABI/testing/sysfs-bus-iio b/Documentation/ABI/testing/sysfs-bus-iio > index 731146c3b138..43e481aed5b2 100644 > --- a/Documentation/ABI/testing/sysfs-bus-iio > +++ b/Documentation/ABI/testing/sysfs-bus-iio > @@ -1312,6 +1312,13 @@ Description: > standardised CIE Erythemal Action Spectrum. UV index values range > from 0 (low) to >=11 (extreme). > > +What: /sys/.../iio:deviceX/in_intensityY_white_raw > +KernelVersion: 4.18 > +Contact: linux-iio@vger.kernel.org > +Description: > + Modifier white indicates that measurements contain white LED > + component. > + > What: /sys/.../iio:deviceX/in_intensity_red_integration_time > What: /sys/.../iio:deviceX/in_intensity_green_integration_time > What: /sys/.../iio:deviceX/in_intensity_blue_integration_time > diff --git a/drivers/iio/industrialio-core.c b/drivers/iio/industrialio-core.c > index 19bdf3d2962a..cb939b9fad16 100644 > --- a/drivers/iio/industrialio-core.c > +++ b/drivers/iio/industrialio-core.c > @@ -108,6 +108,7 @@ static const char * const iio_modifier_names[] = { > [IIO_MOD_LIGHT_GREEN] = "green", > [IIO_MOD_LIGHT_BLUE] = "blue", > [IIO_MOD_LIGHT_UV] = "uv", > + [IIO_MOD_LIGHT_WHITE] = "white", > [IIO_MOD_QUATERNION] = "quaternion", > [IIO_MOD_TEMP_AMBIENT] = "ambient", > [IIO_MOD_TEMP_OBJECT] = "object", > diff --git a/include/uapi/linux/iio/types.h b/include/uapi/linux/iio/types.h > index 4213cdf88e3c..de87a6c7e6de 100644 > --- a/include/uapi/linux/iio/types.h > +++ b/include/uapi/linux/iio/types.h > @@ -84,6 +84,7 @@ enum iio_modifier { > IIO_MOD_CO2, > IIO_MOD_VOC, > IIO_MOD_LIGHT_UV, > + IIO_MOD_LIGHT_WHITE, > }; > > enum iio_event_type { > diff --git a/tools/iio/iio_event_monitor.c b/tools/iio/iio_event_monitor.c > index b61245e1181d..a2f9c62a79dd 100644 > --- a/tools/iio/iio_event_monitor.c > +++ b/tools/iio/iio_event_monitor.c > @@ -96,6 +96,7 @@ static const char * const iio_modifier_names[] = { > [IIO_MOD_LIGHT_GREEN] = "green", > [IIO_MOD_LIGHT_BLUE] = "blue", > [IIO_MOD_LIGHT_UV] = "uv", > + [IIO_MOD_LIGHT_WHITE] = "white", > [IIO_MOD_QUATERNION] = "quaternion", > [IIO_MOD_TEMP_AMBIENT] = "ambient", > [IIO_MOD_TEMP_OBJECT] = "object", > @@ -178,6 +179,7 @@ static bool event_is_known(struct iio_event_data *event) > case IIO_MOD_LIGHT_GREEN: > case IIO_MOD_LIGHT_BLUE: > case IIO_MOD_LIGHT_UV: > + case IIO_MOD_LIGHT_WHITE: > case IIO_MOD_QUATERNION: > case IIO_MOD_TEMP_AMBIENT: > case IIO_MOD_TEMP_OBJECT: > -- Peter Meerwald-Stadler Mobile: +43 664 24 44 418