linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Rik van Riel <riel@surriel.com>, Mike Galbraith <efault@gmx.de>,
	Dave Hansen <dave.hansen@intel.com>
Subject: Re: Build failures with gcc 4.5 and older
Date: Mon, 20 Aug 2018 16:53:13 +0200 (CEST)	[thread overview]
Message-ID: <alpine.DEB.2.21.1808201652420.1551@nanos.tec.linutronix.de> (raw)
In-Reply-To: <87ca655c-e73a-286f-e69d-30fed9d00d77@roeck-us.net>

On Tue, 14 Aug 2018, Guenter Roeck wrote:
> On 08/14/2018 04:20 PM, Linus Torvalds wrote:
> > On Tue, Aug 14, 2018 at 4:02 PM Andrew Morton <akpm@linux-foundation.org>
> > wrote:
> > > 
> > > The m68k build still fails because 0cc3cd21657 ("cpu/hotplug: Boot HT
> > > siblings at least once") was evidently never tested on CONFIG_SMP=n.
> > > How could that come about - the patch is six weeks old??
> > 
> > Ehh, meet the joys of embargoes.
> > 
> > The code was tested (and people even found subtle arm64 problems due
> > to that testing), but because it couldn't be made public until today,
> > it didn't go through all the usual infrastructure we depend on.
> > 
> > But:
> > 
> > > kernel/cpu.c: In function 'boot_cpu_hotplug_init':
> > > kernel/cpu.c:2275:2: error: 'struct cpuhp_cpu_state' has no member named
> > > 'booted_once'
> > 
> > it should be fixed now in -git.
> > 
> > > @@ -490,6 +490,8 @@ struct mm_struct {
> > >   #endif
> > >          } __randomize_layout;
> > > 
> > > +       int wibble;
> > > +
> > 
> > Can we call this something informative? Like
> > 
> >          int __gcc_4_4_is_garbage_that_shouldnt_be_used;
> > 
> > or something?
> > 
> > That is, if we actually want to really drag out this whole pointless
> > pain of allowing ancient compilers?
> > 
> > Guys, at some point we need to switch to 4.6. The people who feel the
> > pain today *will* feel the pain at some point. Just get it over with
> > already.
> > 
> 
> For my part I am all for making gcc 4.6 mandatory.

No objections from my side.

Thanks,

	tglx

  reply	other threads:[~2018-08-20 14:53 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-14 17:09 Build failures with gcc 4.5 and older Guenter Roeck
2018-08-14 17:20 ` Linus Torvalds
2018-08-14 17:36   ` Guenter Roeck
2018-08-14 20:19     ` Tony Luck
2018-08-15 16:09       ` Tony Luck
2018-08-15 16:34         ` Linus Torvalds
2018-08-16  0:27           ` Guenter Roeck
2018-08-15 16:49         ` Guenter Roeck
2018-08-14 17:48 ` Joe Perches
2018-08-19 21:23   ` Kees Cook
2018-08-20 17:46   ` Nick Desaulniers
2018-08-20 18:34     ` Linus Torvalds
2018-08-14 21:36 ` Andrew Morton
2018-08-14 22:15   ` Guenter Roeck
2018-08-14 23:02     ` Andrew Morton
2018-08-14 23:20       ` Linus Torvalds
2018-08-15  1:02         ` Guenter Roeck
2018-08-20 14:53           ` Thomas Gleixner [this message]
2018-08-20 16:00             ` Arnd Bergmann
2018-08-15 12:40 ` David Laight
2018-08-15 15:44   ` Linus Torvalds
2018-08-15 16:18     ` David Laight
2018-08-15 16:33       ` Linus Torvalds
2018-08-16  9:17         ` David Laight

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.21.1808201652420.1551@nanos.tec.linutronix.de \
    --to=tglx@linutronix.de \
    --cc=akpm@linux-foundation.org \
    --cc=dave.hansen@intel.com \
    --cc=efault@gmx.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=riel@surriel.com \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).