From: Thomas Gleixner <tglx@linutronix.de>
To: Mukesh Ojha <mojha@codeaurora.org>
Cc: lkml <linux-kernel@vger.kernel.org>
Subject: Re: Query on skip_onerr field in struct cpuhp_step
Date: Sat, 25 Aug 2018 20:27:58 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.21.1808252025590.1195@nanos.tec.linutronix.de> (raw)
In-Reply-To: <a8599754-5c8b-1667-1685-901f53319064@codeaurora.org>
On Tue, 21 Aug 2018, Mukesh Ojha wrote:
> On 8/21/2018 7:27 PM, Thomas Gleixner wrote:
> > > If it is specifically was dependent on notifiers, did we missed to remove
> > > it as the notifiers are gone or the usecase still there?
> > As the comment says....
>
> Thanks for your reply
> Sorry, for further question but i did not get the comment ..did you mean, we
> can remove this from the structure as notifier are not their now. ?
Yes, that's why the comment for that member says: Remove after conversion.
> Also if you are aware with the history, can you tell , why would i want to
> avoid a call in undo_cpu_up path?
Because the notifiers worked completely differently. Go back in the
git history where the initial conversion from notifiers to the state
machine happened.
Thanks,
tglx
prev parent reply other threads:[~2018-08-25 18:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-21 13:47 Query on skip_onerr field in struct cpuhp_step Mukesh Ojha
2018-08-21 13:57 ` Thomas Gleixner
2018-08-21 14:40 ` Mukesh Ojha
2018-08-25 18:27 ` Thomas Gleixner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.1808252025590.1195@nanos.tec.linutronix.de \
--to=tglx@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mojha@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).