From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75D5AC04AB8 for ; Thu, 13 Sep 2018 23:31:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2507720853 for ; Thu, 13 Sep 2018 23:31:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2507720853 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linutronix.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726918AbeINEms (ORCPT ); Fri, 14 Sep 2018 00:42:48 -0400 Received: from Galois.linutronix.de ([146.0.238.70]:46635 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725878AbeINEmr (ORCPT ); Fri, 14 Sep 2018 00:42:47 -0400 Received: from p4fea45ac.dip0.t-ipconnect.de ([79.234.69.172] helo=nanos) by Galois.linutronix.de with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.80) (envelope-from ) id 1g0b4j-0003Ix-IM; Fri, 14 Sep 2018 01:31:05 +0200 Date: Fri, 14 Sep 2018 01:31:05 +0200 (CEST) From: Thomas Gleixner To: Brijesh Singh cc: x86@kernel.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, Tom Lendacky , Borislav Petkov , "H. Peter Anvin" , Paolo Bonzini , Sean Christopherson , =?ISO-8859-2?Q?Radim_Kr=E8m=E1=F8?= Subject: Re: [PATCH v8 2/2] x86/kvm: use __bss_decrypted attribute in shared variables In-Reply-To: <1536875471-17391-3-git-send-email-brijesh.singh@amd.com> Message-ID: References: <1536875471-17391-1-git-send-email-brijesh.singh@amd.com> <1536875471-17391-3-git-send-email-brijesh.singh@amd.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 13 Sep 2018, Brijesh Singh wrote: > > +static void __init kvmclock_init_mem(void) > +{ > + unsigned int ncpus = num_possible_cpus() - HVC_BOOT_ARRAY_SIZE; > + unsigned int order = get_order(ncpus * sizeof(*hvclock_mem)); > + struct page *p; > + int r; > + > + p = alloc_pages(GFP_KERNEL, order); > + if (p) { If you make this: if (!p) { pr_warn(); return; } then you spare one indentation level and give useful information. > + hvclock_mem = page_address(p); > + > + /* > + * hvclock is shared between the guest and the hypervisor, must > + * be mapped decrypted. > + */ > + if (sev_active()) { > + r = set_memory_decrypted((unsigned long) hvclock_mem, > + 1UL << order); > + if (r) { > + __free_pages(p, order); > + hvclock_mem = NULL; This wants a pr_warn() as well, please. > + return; > + } > + } > + > + memset(hvclock_mem, 0, PAGE_SIZE << order); > + } > +} Other than that, this looks really reasonable and way more palatable in the rc stage. Thanks, tglx