From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3651C433F4 for ; Tue, 18 Sep 2018 20:22:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9A05E2133F for ; Tue, 18 Sep 2018 20:22:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9A05E2133F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linutronix.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730356AbeISB4T (ORCPT ); Tue, 18 Sep 2018 21:56:19 -0400 Received: from Galois.linutronix.de ([146.0.238.70]:58684 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729200AbeISB4T (ORCPT ); Tue, 18 Sep 2018 21:56:19 -0400 Received: from p5492e4c1.dip0.t-ipconnect.de ([84.146.228.193] helo=nanos) by Galois.linutronix.de with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.80) (envelope-from ) id 1g2MVT-00022R-EN; Tue, 18 Sep 2018 22:21:59 +0200 Date: Tue, 18 Sep 2018 22:21:58 +0200 (CEST) From: Thomas Gleixner To: "Eric W. Biederman" cc: LKML , linux-arch@vger.kernel.org, Ingo Molnar , x86@kernel.org, Paolo Bonzini , kvm@vger.kernel.org Subject: Re: [REVIEW][PATCH 04/20] signal/x86: Use send_sig_mceerr as apropriate In-Reply-To: <20180918000546.12552-4-ebiederm@xmission.com> Message-ID: References: <87y3bzk6yv.fsf@xmission.com> <20180918000546.12552-4-ebiederm@xmission.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 18 Sep 2018, Eric W. Biederman wrote: CC+ kvm folks > This simplifies the code making it clearer what is going on. > > Signed-off-by: "Eric W. Biederman" Reviewed-by: Thomas Gleixner > --- > arch/x86/kvm/mmu.c | 11 +---------- > 1 file changed, 1 insertion(+), 10 deletions(-) > > diff --git a/arch/x86/kvm/mmu.c b/arch/x86/kvm/mmu.c > index a282321329b5..95349bfe3b59 100644 > --- a/arch/x86/kvm/mmu.c > +++ b/arch/x86/kvm/mmu.c > @@ -3114,16 +3114,7 @@ static int __direct_map(struct kvm_vcpu *vcpu, int write, int map_writable, > > static void kvm_send_hwpoison_signal(unsigned long address, struct task_struct *tsk) > { > - siginfo_t info; > - > - clear_siginfo(&info); > - info.si_signo = SIGBUS; > - info.si_errno = 0; > - info.si_code = BUS_MCEERR_AR; > - info.si_addr = (void __user *)address; > - info.si_addr_lsb = PAGE_SHIFT; > - > - send_sig_info(SIGBUS, &info, tsk); > + send_sig_mceerr(BUS_MCEERR_AR, (void __user *)address, PAGE_SHIFT, tsk); > } > > static int kvm_handle_bad_page(struct kvm_vcpu *vcpu, gfn_t gfn, kvm_pfn_t pfn) > -- > 2.17.1 > >