linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: "Woodhouse, David" <dwmw@amazon.co.uk>
Cc: "mingo@kernel.org" <mingo@kernel.org>,
	"zhenzhong.duan@oracle.com" <zhenzhong.duan@oracle.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"daniel@iogearbox.net" <daniel@iogearbox.net>,
	"peterz@infradead.org" <peterz@infradead.org>,
	"bp@suse.de" <bp@suse.de>,
	"srinivas.eeda@oracle.com" <srinivas.eeda@oracle.com>,
	"konrad.wilk@oracle.com" <konrad.wilk@oracle.com>,
	"michal.lkml@markovi.net" <michal.lkml@markovi.net>,
	"hpa@zytor.com" <hpa@zytor.com>,
	"mingo@redhat.com" <mingo@redhat.com>,
	"yamada.masahiro@socionext.com" <yamada.masahiro@socionext.com>,
	"luto@kernel.org" <luto@kernel.org>
Subject: Re: [PATCH v2 1/2] retpolines: Only enable retpoline support when compiler support it
Date: Thu, 1 Nov 2018 13:17:58 +0100 (CET)	[thread overview]
Message-ID: <alpine.DEB.2.21.1811011317400.1642@nanos.tec.linutronix.de> (raw)
In-Reply-To: <90a9eed724b28d5af57a71694a95b4cd92728ccc.camel@amazon.co.uk>

On Thu, 1 Nov 2018, Woodhouse, David wrote:
> On Thu, 2018-11-01 at 10:50 +0100, Ingo Molnar wrote:
> > * Zhenzhong Duan <zhenzhong.duan@oracle.com> wrote:
> > 
> > > Since retpoline capable compilers are widely available, make
> > > CONFIG_RETPOLINE hard depend on it.
> > > 
> > > The check of RETPOLINE is changed to CONFIG_RETPOLINE.
> > > 
> > > This change is based on suggestion in https://lkml.org/lkml/2018/9/18/1016
> > > 
> > > Signed-off-by: Zhenzhong Duan <zhenzhong.duan@oracle.com>
> > > Cc: Thomas Gleixner <tglx@linutronix.de>
> > > Cc: Peter Zijlstra <peterz@infradead.org>
> > 
> > Please turn such 'based on suggestions' into proper tags as well, i.e. 
> > something like:
> > 
> >   Suggested-by: David Woodhouse <dwmw2@infradead.org>
> 
> I think the suggestion came from PeterZ; I just acked it.
> 
> Although on furthe reflection, I think I'd prefer a build break if
> retpoline is enabled in the kernel config and the compiler doesn't
> support it. This patch would make it silently fail to be secure.

Agreed.

Thanks,

	tglx

  parent reply	other threads:[~2018-11-01 12:18 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-01  9:31 Zhenzhong Duan
2018-11-01  9:50 ` Ingo Molnar
     [not found]   ` <90a9eed724b28d5af57a71694a95b4cd92728ccc.camel@amazon.co.uk>
2018-11-01 12:17     ` Thomas Gleixner [this message]
2018-11-01 14:34       ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.21.1811011317400.1642@nanos.tec.linutronix.de \
    --to=tglx@linutronix.de \
    --cc=bp@suse.de \
    --cc=daniel@iogearbox.net \
    --cc=dwmw@amazon.co.uk \
    --cc=hpa@zytor.com \
    --cc=konrad.wilk@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@kernel.org \
    --cc=michal.lkml@markovi.net \
    --cc=mingo@kernel.org \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=srinivas.eeda@oracle.com \
    --cc=yamada.masahiro@socionext.com \
    --cc=zhenzhong.duan@oracle.com \
    --subject='Re: [PATCH v2 1/2] retpolines: Only enable retpoline support when compiler support it' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).