From: Thomas Gleixner <tglx@linutronix.de>
To: "Zhivich, Michael" <mzhivich@akamai.com>
Cc: John Stultz <john.stultz@linaro.org>,
lkml <linux-kernel@vger.kernel.org>,
"tiny.windzz@gmail.com" <tiny.windzz@gmail.com>,
Joel Fernandes <joel@joelfernandes.org>,
"alexander.levin@verizon.com" <alexander.levin@verizon.com>,
"frederic@kernel.org" <frederic@kernel.org>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
Ingo Molnar <mingo@kernel.org>,
Steven Rostedt <rostedt@goodmis.org>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
Arnd Bergmann <arnd@arndb.de>,
Ondrej Mosnacek <omosnace@redhat.com>,
Jason Wessel <jason.wessel@windriver.com>,
"kreview@akamai.com" <kreview@akamai.com>
Subject: Re: [PATCH] softirq: don't push timer softirq handling to ksoftirqd
Date: Wed, 28 Nov 2018 16:21:52 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.2.21.1811281616570.1532@nanos.tec.linutronix.de> (raw)
In-Reply-To: <6DB365C6-98F6-4C27-B0BE-0833E5D4962E@akamai.com>
Michael,
On Fri, 16 Nov 2018, Zhivich, Michael wrote:
> On 11/15/18, 12:17 PM, "John Stultz" <john.stultz@linaro.org> wrote:
> Would a more focused fix be to move the clocksource watchdog from a
> normal timer to a hrtimer?
>
> That's an interesting idea - it would get clocksource watchdog out of
> ksoftirqd. However, clocksource watchdog iterates over available CPUs to
> check the TSC on each core (see add_timer_on() call in
> clocksource_watchdog()). I'm not seeing an API to start an hrtimer on a
> specific CPU - is this possible and I'm missing it? Or would something
> like this have to be added to hrtimer?
It's surely an interesting idea, but it's not trivial.
There is no way to reliably queue hrtimers remote when high resolution mode
is enabled. It only works when the to be queued timer is not the first to
expire one. If it ends up being the first to expire timer, then there is
currently no way to rearm the remote per cpu clockevent device because it's
not remotely accesible.
It would need an SMP function call, but that needs to be asynchronous due
to locking/interrupt disabled constraints. Maybe ...
Thanks,
tglx
next prev parent reply other threads:[~2018-11-28 15:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-15 17:07 [PATCH] softirq: don't push timer softirq handling to ksoftirqd Michael Zhivich
2018-11-15 17:17 ` John Stultz
2018-11-16 18:46 ` Zhivich, Michael
2018-11-28 15:21 ` Thomas Gleixner [this message]
2018-11-28 17:56 ` [kreview] " Zhivich, Michael
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.1811281616570.1532@nanos.tec.linutronix.de \
--to=tglx@linutronix.de \
--cc=alexander.levin@verizon.com \
--cc=arnd@arndb.de \
--cc=bigeasy@linutronix.de \
--cc=frederic@kernel.org \
--cc=jason.wessel@windriver.com \
--cc=joel@joelfernandes.org \
--cc=john.stultz@linaro.org \
--cc=kreview@akamai.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=mzhivich@akamai.com \
--cc=omosnace@redhat.com \
--cc=paulmck@linux.vnet.ibm.com \
--cc=rostedt@goodmis.org \
--cc=tiny.windzz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).