From: Julia Lawall <julia.lawall@lip6.fr>
To: wen.yang99@zte.com.cn
Cc: Markus.Elfring@web.de, Gilles Muller <Gilles.Muller@lip6.fr>,
nicolas.palix@imag.fr, michal.lkml@markovi.net,
wang.yi59@zte.com.cn, yamada.masahiro@socionext.com,
yellowriver2010@hotmail.com, cheng.shengyu@zte.com.cn,
cocci@systeme.lip6.fr, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [v5] coccinelle: semantic code search for missingput_device()
Date: Sat, 16 Feb 2019 09:41:45 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.2.21.1902160939540.3212@hadrien> (raw)
In-Reply-To: <alpine.DEB.2.21.1902160934400.3212@hadrien>
Actually, upon reflection, I don't like the if (...) solution. if (id !=
NULL) would be better. This will also check for if (id). If having such
an explicit test results in false positives, the semantic patch can be
revised. But it is better than if (...), which allow anything at all, and
could miss cases where the free should happen, but does not.
julia
next prev parent reply other threads:[~2019-02-16 8:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <201902161633004137519@zte.com.cn>
2019-02-16 8:36 ` [v5] coccinelle: semantic code search for missingput_device() Julia Lawall
2019-02-16 8:41 ` Julia Lawall [this message]
2019-02-16 8:57 ` Markus Elfring
2019-02-16 9:06 ` [Cocci] " Wolfram Sang
2019-02-16 9:20 ` Markus Elfring
[not found] <201902161504357846572@zte.com.cn>
2019-02-16 8:09 ` Markus Elfring
2019-02-16 8:34 ` Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.1902160939540.3212@hadrien \
--to=julia.lawall@lip6.fr \
--cc=Gilles.Muller@lip6.fr \
--cc=Markus.Elfring@web.de \
--cc=cheng.shengyu@zte.com.cn \
--cc=cocci@systeme.lip6.fr \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.lkml@markovi.net \
--cc=nicolas.palix@imag.fr \
--cc=wang.yi59@zte.com.cn \
--cc=wen.yang99@zte.com.cn \
--cc=yamada.masahiro@socionext.com \
--cc=yellowriver2010@hotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).