linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: Kees Cook <keescook@chromium.org>
Cc: kbuild-all@01.org, LKML <linux-kernel@vger.kernel.org>,
	tipbuild@zytor.com, kbuild test robot <lkp@intel.com>
Subject: Re: [tip:x86/asm 2/4] arch/x86/include/asm/special_insns.h:31:9: error: 'X86_CR0_WP' undeclared
Date: Wed, 6 Mar 2019 19:23:03 +0100 (CET)	[thread overview]
Message-ID: <alpine.DEB.2.21.1903061922320.1646@nanos.tec.linutronix.de> (raw)
In-Reply-To: <CAGXu5jKiW9-pnKbRh05_SmYm8TwjoRpsrA8472+Gct_YjVr+Jw@mail.gmail.com>

On Wed, 6 Mar 2019, Kees Cook wrote:

> On Wed, Mar 6, 2019 at 3:43 AM kbuild test robot <lkp@intel.com> wrote:
> >
> > tree:   https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git x86/asm
> > head:   a0bf7fc24303a538396aa8d32450d05c1929b9f0
> > commit: d309ba034fac1a149d00cac79318973e9ba81848 [2/4] x86/asm: Pin sensitive CR0 bits
> > config: um-x86_64_defconfig (attached as .config)
> > compiler: gcc-8 (Debian 8.3.0-2) 8.3.0
> > reproduce:
> >         git checkout d309ba034fac1a149d00cac79318973e9ba81848
> >         # save the attached .config to linux build tree
> >         make ARCH=um SUBARCH=x86_64
> 
> Gah, I did not build-test um. :(
> 
> >
> > All errors (new ones prefixed by >>):
> >
> >    In file included from arch/x86/include/asm/cacheflush.h:7,
> >                     from include/linux/highmem.h:12,
> >                     from net//core/sock.c:117:
> >    arch/x86/include/asm/special_insns.h: In function 'native_write_cr0':
> > >> arch/x86/include/asm/special_insns.h:31:9: error: 'X86_CR0_WP' undeclared (first use in this function)
> >      val |= X86_CR0_WP;
> >             ^~~~~~~~~~
> 
> Should I just add something like:
> 
> #ifdef __arch_um__
> # define X86_CR0_WP 0
> #endif

Fixed it up by including the proper header file.

Thanks,

	tglx

      reply	other threads:[~2019-03-06 18:23 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-06 11:42 [tip:x86/asm 2/4] arch/x86/include/asm/special_insns.h:31:9: error: 'X86_CR0_WP' undeclared kbuild test robot
2019-03-06 16:26 ` Kees Cook
2019-03-06 18:23   ` Thomas Gleixner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.21.1903061922320.1646@nanos.tec.linutronix.de \
    --to=tglx@linutronix.de \
    --cc=kbuild-all@01.org \
    --cc=keescook@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=tipbuild@zytor.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).