From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6F335C43381 for ; Tue, 26 Mar 2019 06:44:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 43A552070B for ; Tue, 26 Mar 2019 06:44:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731828AbfCZGo4 (ORCPT ); Tue, 26 Mar 2019 02:44:56 -0400 Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]:65252 "EHLO mail3-relais-sop.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731766AbfCZGow (ORCPT ); Tue, 26 Mar 2019 02:44:52 -0400 X-IronPort-AV: E=Sophos;i="5.60,271,1549926000"; d="scan'208";a="300711454" Received: from abo-58-107-68.mrs.modulonet.fr (HELO hadrien) ([85.68.107.58]) by mail3-relais-sop.national.inria.fr with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Mar 2019 07:44:42 +0100 Date: Tue, 26 Mar 2019 07:44:41 +0100 (CET) From: Julia Lawall X-X-Sender: jll@hadrien To: Greg KH cc: Arnd Bergmann , stable@vger.kernel.org, Ulf Hansson , Janusz Krzysztofik , Linus Walleij , "Tobin C. Harding" , Geert Uytterhoeven , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [BACKPORT 4.4.y 01/25] mmc: pwrseq: constify mmc_pwrseq_ops structures In-Reply-To: <20190326010831.GA29420@kroah.com> Message-ID: References: <20190322154425.3852517-1-arnd@arndb.de> <20190322154425.3852517-2-arnd@arndb.de> <20190326010831.GA29420@kroah.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 26 Mar 2019, Greg KH wrote: > On Fri, Mar 22, 2019 at 04:43:52PM +0100, Arnd Bergmann wrote: > > From: Julia Lawall > > > > The mmc_pwrseq_ops structures are never modified, so declare them as const. > > > > Done with the help of Coccinelle. > > > > Signed-off-by: Julia Lawall > > Signed-off-by: Ulf Hansson > > (cherry picked from commit ffedbd2210f2f4cba490a9205adc11fd1b89a852) > > Signed-off-by: Arnd Bergmann > > --- > > drivers/mmc/core/pwrseq.h | 2 +- > > drivers/mmc/core/pwrseq_emmc.c | 2 +- > > drivers/mmc/core/pwrseq_simple.c | 2 +- > > 3 files changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/drivers/mmc/core/pwrseq.h b/drivers/mmc/core/pwrseq.h > > index 096da48c6a7e..133de0426687 100644 > > --- a/drivers/mmc/core/pwrseq.h > > +++ b/drivers/mmc/core/pwrseq.h > > @@ -16,7 +16,7 @@ struct mmc_pwrseq_ops { > > }; > > > > struct mmc_pwrseq { > > - struct mmc_pwrseq_ops *ops; > > + const struct mmc_pwrseq_ops *ops; > > }; > > > > #ifdef CONFIG_OF > > diff --git a/drivers/mmc/core/pwrseq_emmc.c b/drivers/mmc/core/pwrseq_emmc.c > > index ad4f94ec7e8d..4a82bc77fe49 100644 > > --- a/drivers/mmc/core/pwrseq_emmc.c > > +++ b/drivers/mmc/core/pwrseq_emmc.c > > @@ -51,7 +51,7 @@ static void mmc_pwrseq_emmc_free(struct mmc_host *host) > > kfree(pwrseq); > > } > > > > -static struct mmc_pwrseq_ops mmc_pwrseq_emmc_ops = { > > +static const struct mmc_pwrseq_ops mmc_pwrseq_emmc_ops = { > > .post_power_on = mmc_pwrseq_emmc_reset, > > .free = mmc_pwrseq_emmc_free, > > }; > > diff --git a/drivers/mmc/core/pwrseq_simple.c b/drivers/mmc/core/pwrseq_simple.c > > index d10538bb5e07..2b16263458af 100644 > > --- a/drivers/mmc/core/pwrseq_simple.c > > +++ b/drivers/mmc/core/pwrseq_simple.c > > @@ -87,7 +87,7 @@ static void mmc_pwrseq_simple_free(struct mmc_host *host) > > kfree(pwrseq); > > } > > > > -static struct mmc_pwrseq_ops mmc_pwrseq_simple_ops = { > > +static const struct mmc_pwrseq_ops mmc_pwrseq_simple_ops = { > > .pre_power_on = mmc_pwrseq_simple_pre_power_on, > > .post_power_on = mmc_pwrseq_simple_post_power_on, > > .power_off = mmc_pwrseq_simple_power_off, > > Why is this needed for a stable patch? It doesn't fix a bug, it just > looks like it is a "nice thing" to have, right? I don't think any later > patch in this series relies it it, or am I missing something? Fine with me. julia