From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8C1EC43381 for ; Tue, 26 Mar 2019 21:11:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9F6EF20823 for ; Tue, 26 Mar 2019 21:11:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732749AbfCZVL1 (ORCPT ); Tue, 26 Mar 2019 17:11:27 -0400 Received: from Galois.linutronix.de ([146.0.238.70]:49395 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732118AbfCZVL0 (ORCPT ); Tue, 26 Mar 2019 17:11:26 -0400 Received: from p5492e2fc.dip0.t-ipconnect.de ([84.146.226.252] helo=nanos) by Galois.linutronix.de with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.80) (envelope-from ) id 1h8tLp-0006S7-8T; Tue, 26 Mar 2019 22:11:17 +0100 Date: Tue, 26 Mar 2019 22:11:16 +0100 (CET) From: Thomas Gleixner To: Ricardo Neri cc: Ingo Molnar , Borislav Petkov , Ashok Raj , Andi Kleen , Peter Zijlstra , "Ravi V. Shankar" , x86@kernel.org, linux-kernel@vger.kernel.org, Ricardo Neri , "H. Peter Anvin" , Tony Luck , Clemens Ladisch , Arnd Bergmann , Philippe Ombredanne , Kate Stewart , "Rafael J. Wysocki" Subject: Re: [RFC PATCH v2 05/14] x86/hpet: Relocate flag definitions to a header file In-Reply-To: <1551283518-18922-6-git-send-email-ricardo.neri-calderon@linux.intel.com> Message-ID: References: <1551283518-18922-1-git-send-email-ricardo.neri-calderon@linux.intel.com> <1551283518-18922-6-git-send-email-ricardo.neri-calderon@linux.intel.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 27 Feb 2019, Ricardo Neri wrote: > Users of HPET timers (such as the hardlockup detector) need the definitions > of these flags to interpret the configuration of a timer as passed by > platform code. Which platform code? > +#define HPET_DEV_USED_BIT 2 > +#define HPET_DEV_USED (1 << HPET_DEV_USED_BIT) > +#define HPET_DEV_VALID 0x8 > +#define HPET_DEV_FSB_CAP 0x1000 > +#define HPET_DEV_PERI_CAP 0x2000 I'm not seing why you would need any of those in the watchdog code. The only function related to the watchdog which needs these is hpet_hardlockup_detector_assign_timer() and that is located in hpet.c itself. Thanks, tglx