From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EB106C43381 for ; Tue, 26 Mar 2019 21:21:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BE12E206C0 for ; Tue, 26 Mar 2019 21:21:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732003AbfCZVVc (ORCPT ); Tue, 26 Mar 2019 17:21:32 -0400 Received: from Galois.linutronix.de ([146.0.238.70]:49480 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726811AbfCZVVc (ORCPT ); Tue, 26 Mar 2019 17:21:32 -0400 Received: from p5492e2fc.dip0.t-ipconnect.de ([84.146.226.252] helo=nanos) by Galois.linutronix.de with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.80) (envelope-from ) id 1h8tUw-0006Zt-09; Tue, 26 Mar 2019 22:20:42 +0100 Date: Tue, 26 Mar 2019 22:20:41 +0100 (CET) From: Thomas Gleixner To: Ricardo Neri cc: "Paul E. McKenney" , Ingo Molnar , Borislav Petkov , Ashok Raj , Andi Kleen , Peter Zijlstra , "Ravi V. Shankar" , x86@kernel.org, linux-kernel@vger.kernel.org, Ricardo Neri , "H. Peter Anvin" , Tony Luck , "Rafael J. Wysocki" , Don Zickus , Nicholas Piggin , Michael Ellerman , Frederic Weisbecker , Alexei Starovoitov , Babu Moger , "David S. Miller" , Benjamin Herrenschmidt , Paul Mackerras , Mathieu Desnoyers , Masami Hiramatsu , Andrew Morton , Philippe Ombredanne , Colin Ian King , Byungchul Park , "Luis R. Rodriguez" , Waiman Long , Josh Poimboeuf , Randy Dunlap , Davidlohr Bueso , Christoffer Dall , Marc Zyngier , Kai-Heng Feng , Konrad Rzeszutek Wilk , David Rientjes , sparclinux@vger.kernel.org, linuxppc-dev@lists.ozlabs.org Subject: Re: [RFC PATCH v2 09/14] watchdog/hardlockup: Make arch_touch_nmi_watchdog() to hpet-based implementation In-Reply-To: <20190301011713.GA8058@ranerica-svr.sc.intel.com> Message-ID: References: <1551283518-18922-1-git-send-email-ricardo.neri-calderon@linux.intel.com> <1551283518-18922-10-git-send-email-ricardo.neri-calderon@linux.intel.com> <20190227161758.GE4072@linux.ibm.com> <20190301011713.GA8058@ranerica-svr.sc.intel.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 28 Feb 2019, Ricardo Neri wrote: > > > > > > -#if defined(CONFIG_HARDLOCKUP_DETECTOR_PERF) > > > +#if defined(CONFIG_HARDLOCKUP_DETECTOR_PERF) || \ > > > + defined(CONFIG_X86_HARDLOCKUP_DETECTOR_HPET) > > > > Why not instead make CONFIG_X86_HARDLOCKUP_DETECTOR_HPET select > > CONFIG_HARDLOCKUP_DETECTOR_PERF? Keep the arch-specific details > > in the arch-specific files and all that. > > Thanks for your feedback, Paul! The HPET implementation does not use > perf. Thus, in my opinion is not correct for the HPET HLD to select > the perf implementation. Patch 8 of this series splits the perf-specific > code and the generic hardlockup detector code. Does this make sense? That's what intermediate config symbols are for. config HARDLOCKUP_DETECTOR_CORE bool And make both PERF and HPET select it. Thanks, tglx