linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: "Dmitry V. Levin" <ldv@altlinux.org>
Cc: Oleg Nesterov <oleg@redhat.com>,
	Steven Rostedt <rostedt@goodmis.org>,
	"Gustavo A. R. Silva" <gustavo@embeddedor.com>,
	Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
	"H. Peter Anvin" <hpa@zytor.com>,
	x86@kernel.org, LKML <linux-kernel@vger.kernel.org>,
	Dominik Brodowski <linux@dominikbrodowski.net>,
	Andy Lutomirski <luto@kernel.org>,
	Kees Cook <keescook@chromium.org>,
	"Eric W. Biederman" <ebiederm@xmission.com>
Subject: Re: [PATCH v2] x86/syscalls: Mark expected switch fall-throughs
Date: Wed, 27 Mar 2019 23:52:19 +0100 (CET)	[thread overview]
Message-ID: <alpine.DEB.2.21.1903272351110.1789@nanos.tec.linutronix.de> (raw)
In-Reply-To: <20190327222014.GA32540@altlinux.org>

On Thu, 28 Mar 2019, Dmitry V. Levin wrote:
> On Wed, Mar 27, 2019 at 03:29:16PM +0100, Thomas Gleixner wrote:
> > On Wed, 27 Mar 2019, Dmitry V. Levin wrote:
> > > On Tue, Mar 26, 2019 at 04:12:45PM +0100, Oleg Nesterov wrote:
> > > > On 03/23, Thomas Gleixner wrote:
> > > [...]
> > > > >  2) syscall_set_arguments() has been introduced in 2008 and we still have
> > > > >     no caller. Instead of polishing it, can it be removed completely or are
> > > > >     there plans to actually use it?
> > > > 
> > > > I think it can die.
> > > 
> > > When PTRACE_GET_SYSCALL_INFO is finally squeezed into the kernel,
> > > we could discuss adding PTRACE_SET_SYSCALL_INFO as well, and it
> > > will need syscall_set_arguments().
> > 
> > So if that ever happens, then adding the code back isn't rocket
> > science. But if not, then there is no point in carrying the dead horse
> > around another 11 years.
> 
> Given that it took me roughly 4 months to get a relatively simple revert
> of commit 5e937a9ae913 accepted into linux-next, adding the code back
> might be time-consuming.
> 
> Could we delay the removal of syscall_set_arguments() until
> PTRACE_GET_SYSCALL_INFO is merged into the kernel?
> I hope it won't take another 11 years.

Hope dies last :)

Seriously. If we keep it can we at least remove all the unused arguments
which we have on both functions to simplify the whole mess?

Thanks,

	tglx

  reply	other threads:[~2019-03-27 22:52 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-28 19:27 [PATCH v2] x86/syscalls: Mark expected switch fall-throughs Gustavo A. R. Silva
2019-03-23 16:14 ` Thomas Gleixner
2019-03-26 15:12   ` Oleg Nesterov
2019-03-26 16:09     ` Thomas Gleixner
2019-03-26 16:16       ` Steven Rostedt
2019-03-26 16:17         ` Thomas Gleixner
2019-03-27  1:26     ` Dmitry V. Levin
2019-03-27 14:29       ` Thomas Gleixner
2019-03-27 22:20         ` Dmitry V. Levin
2019-03-27 22:52           ` Thomas Gleixner [this message]
2019-03-27 23:03             ` Steven Rostedt
2019-03-27 23:12             ` Dmitry V. Levin
2019-03-27 23:15               ` Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.21.1903272351110.1789@nanos.tec.linutronix.de \
    --to=tglx@linutronix.de \
    --cc=bp@alien8.de \
    --cc=ebiederm@xmission.com \
    --cc=gustavo@embeddedor.com \
    --cc=hpa@zytor.com \
    --cc=keescook@chromium.org \
    --cc=ldv@altlinux.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@dominikbrodowski.net \
    --cc=luto@kernel.org \
    --cc=mingo@redhat.com \
    --cc=oleg@redhat.com \
    --cc=rostedt@goodmis.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).