From: David Rientjes <rientjes@google.com>
To: Vlastimil Babka <vbabka@suse.cz>
Cc: "Tobin C. Harding" <tobin@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Christoph Lameter <cl@linux.com>,
Pekka Enberg <penberg@kernel.org>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>, Tejun Heo <tj@kernel.org>,
Qian Cai <cai@lca.pw>,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Mel Gorman <mgorman@techsingularity.net>
Subject: Re: [PATCH 0/1] mm: Remove the SLAB allocator
Date: Wed, 10 Apr 2019 14:53:34 -0700 (PDT) [thread overview]
Message-ID: <alpine.DEB.2.21.1904101452340.100430@chino.kir.corp.google.com> (raw)
In-Reply-To: <f06aaeae-28c0-9ea4-d795-418ec3362d17@suse.cz>
On Wed, 10 Apr 2019, Vlastimil Babka wrote:
> On 4/10/19 4:47 AM, Tobin C. Harding wrote:
> > Recently a 2 year old bug was found in the SLAB allocator that crashes
> > the kernel. This seems to imply that not that many people are using the
> > SLAB allocator.
>
> AFAIK that bug required CONFIG_DEBUG_SLAB_LEAK, not just SLAB. That
> seems to imply not that many people are using SLAB when debugging and
> yeah, SLUB has better debugging support. But I wouldn't dare to make the
> broader implication :)
>
> > Currently we have 3 slab allocators. Two is company three is a crowd -
> > let's get rid of one.
> >
> > - The SLUB allocator has been the default since 2.6.23
>
> Yeah, with a sophisticated reasoning :)
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=a0acd820807680d2ccc4ef3448387fcdbf152c73
>
> > - The SLOB allocator is kinda sexy. Its only 664 LOC, the general
> > design is outlined in KnR, and there is an optimisation taken from
> > Knuth - say no more.
> >
> > If you are using the SLAB allocator please speak now or forever hold your peace ...
>
> FWIW, our enterprise kernel use it (latest is 4.12 based), and openSUSE
> kernels as well (with openSUSE Tumbleweed that includes latest
> kernel.org stables). AFAIK we don't enable SLAB_DEBUG even in general
> debug kernel flavours as it's just too slow.
>
> IIRC last time Mel evaluated switching to SLUB, it wasn't a clear
> winner, but I'll just CC him for details :)
>
We also use CONFIG_SLAB and disable CONFIG_SLAB_DEBUG for the same reason.
next prev parent reply other threads:[~2019-04-10 21:53 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-10 2:47 [PATCH 0/1] mm: Remove the SLAB allocator Tobin C. Harding
2019-04-10 2:47 ` [PATCH 1/1] mm: Remove " Tobin C. Harding
2019-04-10 8:02 ` [PATCH 0/1] mm: Remove the " Vlastimil Babka
2019-04-10 8:16 ` Tobin C. Harding
2019-04-11 7:55 ` Michal Hocko
2019-04-11 8:27 ` Pekka Enberg
2019-04-17 8:50 ` Jesper Dangaard Brouer
2019-04-17 13:27 ` Christopher Lameter
2019-04-17 13:38 ` Michal Hocko
2019-04-22 14:43 ` Jesper Dangaard Brouer
2019-04-11 8:44 ` Mel Gorman
2019-04-10 21:53 ` David Rientjes [this message]
2019-04-12 11:28 ` Mel Gorman
2019-04-17 3:52 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.1904101452340.100430@chino.kir.corp.google.com \
--to=rientjes@google.com \
--cc=akpm@linux-foundation.org \
--cc=cai@lca.pw \
--cc=cl@linux.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@techsingularity.net \
--cc=penberg@kernel.org \
--cc=tj@kernel.org \
--cc=tobin@kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).