From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 39F29C10F0E for ; Thu, 18 Apr 2019 22:45:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 16D7920693 for ; Thu, 18 Apr 2019 22:45:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726289AbfDRWo7 (ORCPT ); Thu, 18 Apr 2019 18:44:59 -0400 Received: from Galois.linutronix.de ([146.0.238.70]:39427 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725855AbfDRWo6 (ORCPT ); Thu, 18 Apr 2019 18:44:58 -0400 Received: from pd9ef12d2.dip0.t-ipconnect.de ([217.239.18.210] helo=nanos) by Galois.linutronix.de with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.80) (envelope-from ) id 1hHFlT-0000Hv-O2; Fri, 19 Apr 2019 00:44:19 +0200 Date: Fri, 19 Apr 2019 00:44:17 +0200 (CEST) From: Thomas Gleixner To: Steven Rostedt cc: LKML , Josh Poimboeuf , x86@kernel.org, Andy Lutomirski , Alexander Potapenko , Alexey Dobriyan , Andrew Morton , Pekka Enberg , linux-mm@kvack.org, David Rientjes , Christoph Lameter , Catalin Marinas , Dmitry Vyukov , Andrey Ryabinin , kasan-dev@googlegroups.com, Mike Rapoport , Akinobu Mita , iommu@lists.linux-foundation.org, Robin Murphy , Christoph Hellwig , Marek Szyprowski , Johannes Thumshirn , David Sterba , Chris Mason , Josef Bacik , linux-btrfs@vger.kernel.org, dm-devel@redhat.com, Mike Snitzer , Alasdair Kergon , intel-gfx@lists.freedesktop.org, Joonas Lahtinen , Maarten Lankhorst , dri-devel@lists.freedesktop.org, David Airlie , Jani Nikula , Daniel Vetter , Rodrigo Vivi , linux-arch@vger.kernel.org Subject: Re: [patch V2 01/29] tracing: Cleanup stack trace code In-Reply-To: <20190418181938.2e2a9a04@gandalf.local.home> Message-ID: References: <20190418084119.056416939@linutronix.de> <20190418084253.142712304@linutronix.de> <20190418181938.2e2a9a04@gandalf.local.home> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 18 Apr 2019, Steven Rostedt wrote: > On Thu, 18 Apr 2019 10:41:20 +0200 > Thomas Gleixner wrote: > > > @@ -412,23 +404,20 @@ stack_trace_sysctl(struct ctl_table *tab > > void __user *buffer, size_t *lenp, > > loff_t *ppos) > > { > > - int ret; > > + int ret, was_enabled; > > One small nit. Could this be: > > int was_enabled; > int ret; > > I prefer only joining variables that are related on the same line. > Makes it look cleaner IMO. If you wish so. To me it's waste of screen space :) > > > > mutex_lock(&stack_sysctl_mutex); > > + was_enabled = !!stack_tracer_enabled; > > > > Bah, not sure why I didn't do it this way to begin with. I think I > copied something else that couldn't do it this way for some reason and > didn't put any brain power behind the copy. :-/ But that was back in > 2008 so I blame it on being "young and stupid" ;-) The young part is gone for sure :) > Other then the above nit and removing the unneeded +1 in max_entries: s/+1/-1/ Thanks, tglx