From: Thomas Gleixner <tglx@linutronix.de>
To: Anson.Huang@nxp.com
Cc: daniel.lezcano@linaro.org, robh+dt@kernel.org,
mark.rutland@arm.com, shawnguo@kernel.org,
s.hauer@pengutronix.de, kernel@pengutronix.de,
festevam@gmail.com, l.stach@pengutronix.de, abel.vesa@nxp.com,
ccaione@baylibre.com, angus@akkea.ca, andrew.smirnov@gmail.com,
agx@sigxcpu.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
Linux-imx@nxp.com
Subject: Re: [PATCH V2 2/3] clocksource: imx-sysctr: Add of_clk skip option
Date: Sun, 23 Jun 2019 14:17:31 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.21.1906231413110.32342@nanos.tec.linutronix.de> (raw)
In-Reply-To: <20190623120434.19556-2-Anson.Huang@nxp.com>
On Sun, 23 Jun 2019, Anson.Huang@nxp.com wrote:
Again the short summary could be more informative. Instead of 'Add foo' you
could say:
.....: Make timer work with platform driver model
That sums up the real meat of the patch. 'Add some option' is pretty
uninformative.
> On some i.MX8M platforms, clock driver uses platform driver
> model and it is NOT ready during timer initialization phase,
> the clock operations will fail and system counter driver will
> fail too. As all the i.MX8M platforms' system counter clock
> are from OSC which is always enabled, so it is no need to enable
> clock for system counter driver, the ONLY thing is to pass
> clock frequence to driver.
>
> This patch adds an option of skipping of_clk operation for
> system counter driver, an optional property "clock-frequency"
> is introduced to pass the frequency value to system counter
> driver and indicate driver to skip of_clk operations.
The comments to the changelog of patch 1 apply here as well :)
Hint: 'This patch'
Thanks,
tglx
next prev parent reply other threads:[~2019-06-23 12:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-23 12:04 [PATCH V2 1/3] clocksource/drivers/sysctr: Add optional clock-frequency property Anson.Huang
2019-06-23 12:04 ` [PATCH V2 2/3] clocksource: imx-sysctr: Add of_clk skip option Anson.Huang
2019-06-23 12:17 ` Thomas Gleixner [this message]
2019-06-23 12:24 ` Anson Huang
2019-06-23 12:04 ` [PATCH V2 3/3] arm64: dts: imx8mq: Add system counter node Anson.Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.1906231413110.32342@nanos.tec.linutronix.de \
--to=tglx@linutronix.de \
--cc=Anson.Huang@nxp.com \
--cc=Linux-imx@nxp.com \
--cc=abel.vesa@nxp.com \
--cc=agx@sigxcpu.org \
--cc=andrew.smirnov@gmail.com \
--cc=angus@akkea.ca \
--cc=ccaione@baylibre.com \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=l.stach@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).