From: Thomas Gleixner <tglx@linutronix.de>
To: Octavio Alvarez <octallk1@alvarezp.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>,
x86@kernel.org, Ingo Molnar <mingo@redhat.com>,
Borislav Petkov <bp@alien8.de>, "H. Peter Anvin" <hpa@zytor.com>,
Marc Zyngier <marc.zyngier@arm.com>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
"Steven Rostedt (VMware)" <rostedt@goodmis.org>,
Jiang Biao <jiang.biao2@zte.com.cn>,
Yi Wang <wang.yi59@zte.com.cn>,
Dou Liyang <douly.fnst@cn.fujitsu.com>,
Nicolai Stange <nstange@suse.de>,
Mirko Lindner <mlindner@marvell.com>,
Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: PROBLEM: Marvell 88E8040 (sky2) fails after hibernation
Date: Thu, 27 Jun 2019 16:38:30 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.21.1906271632300.32342@nanos.tec.linutronix.de> (raw)
In-Reply-To: <098de4c3-5f71-f84d-8b49-d2f43e18ed91@alvarezp.org>
Octavio,
On Mon, 24 Jun 2019, Octavio Alvarez wrote:
> On 6/23/19 7:54 AM, Thomas Gleixner wrote:
> > Load the driver on Linus master with the following module parameter:
> >
> > disable_msi=1
> >
> > That switches to INTx usage. Does the machine resume proper with that?
>
> I did two tests:
>
> If I boot with sky2.disable_msi=1 on the kernel cmdline then the problem goes
> away (when back from hibernation, the NIC works OK).
>
> If I boot regularly (disable_msi not set) and then do modprobe -r sky2;
> modprobe sky2 disable_msi=1, the problem stays (when back from hibernation,
> the NIC does not work).
Interesting. Did you verify that the driver still uses INTx after
hibernation in /proc/interrupts?
cat /proc/interrupts | grep eth0
The 6st column should show IO-APIC for INTx. If it shows PCI-MSI then
something went wrong.
Also please check Linus suspicion about the module being reloaded after
hibernation through some distro magic.
Thanks,
tglx
next prev parent reply other threads:[~2019-06-27 14:38 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <aba1c363-92de-66d7-4aac-b555f398e70a@alvarezp.org>
2019-06-01 13:16 ` PROBLEM: Marvell 88E8040 (sky2) fails after hibernation Octavio Alvarez
2019-06-13 5:02 ` Octavio Alvarez
2019-06-13 20:45 ` Thomas Gleixner
2019-06-20 1:37 ` Octavio Alvarez
2019-06-22 13:27 ` Thomas Gleixner
2019-06-23 12:54 ` Thomas Gleixner
2019-06-24 15:36 ` Stephen Hemminger
2019-06-24 15:39 ` Thomas Gleixner
2019-06-24 17:08 ` Octavio Alvarez
2019-06-24 19:48 ` Linus Torvalds
2019-06-27 14:38 ` Thomas Gleixner [this message]
2019-07-15 16:40 ` Octavio Alvarez
2019-07-15 19:09 ` Thomas Gleixner
2019-07-15 20:40 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.1906271632300.32342@nanos.tec.linutronix.de \
--to=tglx@linutronix.de \
--cc=bp@alien8.de \
--cc=douly.fnst@cn.fujitsu.com \
--cc=hpa@zytor.com \
--cc=jiang.biao2@zte.com.cn \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=mingo@redhat.com \
--cc=mlindner@marvell.com \
--cc=nstange@suse.de \
--cc=octallk1@alvarezp.org \
--cc=rafael.j.wysocki@intel.com \
--cc=rostedt@goodmis.org \
--cc=stephen@networkplumber.org \
--cc=torvalds@linux-foundation.org \
--cc=wang.yi59@zte.com.cn \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).