From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9140EC4321A for ; Thu, 27 Jun 2019 22:44:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5C8B32086D for ; Thu, 27 Jun 2019 22:44:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726682AbfF0Wot (ORCPT ); Thu, 27 Jun 2019 18:44:49 -0400 Received: from Galois.linutronix.de ([193.142.43.55]:60009 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726514AbfF0Wos (ORCPT ); Thu, 27 Jun 2019 18:44:48 -0400 Received: from p5b06daab.dip0.t-ipconnect.de ([91.6.218.171] helo=nanos) by Galois.linutronix.de with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.80) (envelope-from ) id 1hgd8B-00022x-EQ; Fri, 28 Jun 2019 00:44:40 +0200 Date: Fri, 28 Jun 2019 00:44:38 +0200 (CEST) From: Thomas Gleixner To: Ingo Molnar cc: LKML , x86@kernel.org, Peter Zijlstra , Ricardo Neri , Ashok Raj , Andi Kleen , Suravee Suthikulpanit , Stephane Eranian , Ravi Shankar Subject: Re: [patch 26/29] x86/hpet: Consolidate clockevent functions In-Reply-To: <20190626211753.GB101255@gmail.com> Message-ID: References: <20190623132340.463097504@linutronix.de> <20190623132436.461437795@linutronix.de> <20190626211753.GB101255@gmail.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 26 Jun 2019, Ingo Molnar wrote: > * Thomas Gleixner wrote: > > - evt->set_state_shutdown = hpet_msi_shutdown; > > - evt->set_state_oneshot = hpet_msi_set_oneshot; > > - evt->tick_resume = hpet_msi_resume; > > - evt->set_next_event = hpet_msi_next_event; > > + evt->set_state_shutdown = hpet_clkevt_shutdown; > > + evt->set_state_oneshot = hpet_clkevt_set_oneshot; > > + evt->set_next_event = hpet_clkevt_set_next_event; > > + evt->tick_resume = hpet_clkevt_msi_resume; > > evt->cpumask = cpumask_of(hc->cpu); > > My compulsive-obsessive half really wants this to look like: > > > + evt->set_state_shutdown = hpet_clkevt_shutdown; > > + evt->set_state_oneshot = hpet_clkevt_set_oneshot; > > + evt->set_next_event = hpet_clkevt_set_next_event; > > + evt->tick_resume = hpet_clkevt_msi_resume; > > evt->cpumask = cpumask_of(hc->cpu); Just to remove all of that in the next patch again, which then has the proper aligned thing to make you happy :) > Also, maybe harmonize the callback names with the local function names, > like hpet_clkevt_set_next_event() already does and > hpet_clkevt_set_oneshot() almost does: > > s/hpet_clkevt_shutdown > /hpet_clkevt_set_state_shutdown > > s/hpet_clkevt_set_oneshot > /hpet_clkevt_set_state_oneshot > > s/hpet_clkevt_msi_resume > /hpet_clkevt_tick_resume > > ... unless the name variations have some hidden purpose and meaning? Historical but we want to preserve some of the old stuff for sentimental reasons. Thanks, tglx